Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various ripping issues #179

Closed
ghost opened this issue Jul 15, 2017 · 5 comments
Closed

Various ripping issues #179

ghost opened this issue Jul 15, 2017 · 5 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Milestone

Comments

@ghost
Copy link

ghost commented Jul 15, 2017

  • wihpper cd rip doesn't exit after fetching and displaying metadata (even if it can't do anything without -p or -R).
  • After selecting the release (with -p), there's no way to know it's not stuck (maybe some progress status or at least a message?). Only by seeing the cdrdao CPU usage we can know it's doing something.
  • whipper cd rip -h lacks newlines between the template format description entries.
Rips a CD. Tracks are named according to the track template, filling in the
variables and adding the file extension. Variables exclusive to the track
template are:
- %t: track number
- %a: track artist
- %n: track title
- %s: track sort name
Disc files (.cue, .log, .m3u) are named according to the disc
template, filling in the variables and adding the file extension. Variables
for both disc and track template are:
- %A: album artist
- %S: album sort name
- %d: disc title
- %y: release year 
- %r: release type, lowercase
- %R: Release type, normal case
- %x: audio extension, lowercase
- %X: audio extension, uppercase
Paths to track files referenced in .cue and .m3u files
will be made relative to the directory of the disc files. All files will be
created relative to the given output directory. Log files will log the path to
tracks relative to this directory.

instead of

Rips a CD. Tracks are named according to the track template, filling in the
variables and adding the file extension. Variables exclusive to the track
template are: - %t: track number - %a: track artist - %n: track title - %s:
track sort name Disc files (.cue, .log, .m3u) are named according to the disc
template, filling in the variables and adding the file extension. Variables
for both disc and track template are: - %A: album artist - %S: album sort name
- %d: disc title - %y: release year - %r: release type, lowercase - %R:
Release type, normal case - %x: audio extension, lowercase - %X: audio
extension, uppercase Paths to track files referenced in .cue and .m3u files
will be made relative to the directory of the disc files. All files will be
created relative to the given output directory. Log files will log the path to
tracks relative to this directory.
@RecursiveForest
Copy link
Contributor

RecursiveForest commented Aug 4, 2017

Thanks for the bug reports.

For me, if a disc has multiple matching releases on MusicBrainz and -p is not passed, it prints the metadata for each release and then exits with return code 255. Could you give me more information on how you executed whipper to help me recreate?

I agree that whipper is fairly incommunicative about running cdrdao to read the toc, and that the documentation formatting needs some attention; I'm going to deal with those separately.

@JoeLametta
Copy link
Collaborator

JoeLametta commented Apr 6, 2018

Progress update for this issue...

  • After selecting the release (with -p), there's no way to know it's not stuck (maybe some progress status or at least a message?). Only by seeing the cdrdao CPU usage we can know it's doing something. // Fixed with 19eb974.
  • whipper cd rip -h lacks newlines between the template format description entries. // Fixed with Fix appearance of template description text. #223.
  • wihpper cd rip doesn't exit after fetching and displaying metadata (even if it can't do anything without -p or -R).

@JoeLametta
Copy link
Collaborator

For me, if a disc has multiple matching releases on MusicBrainz and -p is not passed, it prints the metadata for each release and then exits with return code 255. Could you give me more information on how you executed whipper to help me recreate?

@q3cpma I haven't checked the remaining issue but could you answer RecursiveForest's question?

Thanks,
Joe

@JoeLametta JoeLametta added this to the 1.0 milestone Apr 6, 2018
@ghost
Copy link
Author

ghost commented Apr 6, 2018 via email

@JoeLametta
Copy link
Collaborator

Honestly, just close the remaining one.

Understood, thanks for the reply!

@JoeLametta JoeLametta added Bug Generic bug: can be used together with more specific labels Accepted Accepted issue on our roadmap and removed enhancement labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Projects
None yet
Development

No branches or pull requests

2 participants