From 067d4f6f374452a08d1d7a5de14dbde0dd8e1570 Mon Sep 17 00:00:00 2001 From: Junjie Gao Date: Mon, 2 Dec 2024 02:32:17 +0000 Subject: [PATCH] fix(test): update Signed-off-by: Junjie Gao --- internal/io/limitedwriter_test.go | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/internal/io/limitedwriter_test.go b/internal/io/limitedwriter_test.go index 59608c93..ac5f5c15 100644 --- a/internal/io/limitedwriter_test.go +++ b/internal/io/limitedwriter_test.go @@ -15,12 +15,12 @@ package io import ( "bytes" + "io" "testing" ) func TestLimitWriter(t *testing.T) { limit := int64(10) - longString := "1234567891011" tests := []struct { input string @@ -46,13 +46,22 @@ func TestLimitWriter(t *testing.T) { if buf.String() != tt.expected { t.Errorf("expected buffer %q, got %q", tt.expected, buf.String()) } + } +} - n, err = lw.Write([]byte(longString)) - if err != nil { - t.Fatalf("unexpected error: %v", err) - } - if n == len(longString) { - t.Errorf("should not write more than the limit") - } +func TestLimitWriterFailed(t *testing.T) { + limit := int64(10) + longString := "1234567891011" + + var buf bytes.Buffer + lw := LimitWriter(&buf, limit) + _, err := lw.Write([]byte(longString)) + if err != nil { + t.Fatalf("unexpected error: %v", err) + } + _, err = lw.Write([]byte(longString)) + expectedErr := io.ErrShortWrite + if err != expectedErr { + t.Errorf("expected error %v, got %v", expectedErr, err) } }