Add batch select #642
Merged
Add batch select #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is inspired by Rails' find_in_batches and is an alternative to using 'fetchSize' that does not rely on server-side cursors.
|
@Tapac may I ask what's the status of this? |
|
Hi @ps-feng , for for a late reply. After that, I expect to get some critical issues (:D), fix them and then merge your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #641.
This functionality is inspired by Rails' find_in_batches and is an alternative to using 'fetchSize' that does not rely on server-side cursors. It's also a much more efficient approach than using limit+offset.
The requirement for this to work is that the source table has an auto-increment column.
@Tapac I used a different naming style for the tests as I felt I needed more words, but if you prefer I can try to use the same format as the other tests.