allow the SQL Server default keyword as default value for a column #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapac
reviewed
Apr 16, 2021
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/vendors/SQLServerDialect.kt
Outdated
Show resolved
Hide resolved
ahayanm001
force-pushed
the
work/default-keyword
branch
from
c89a171 to
ca264b5
Compare
Tapac
added a commit
that referenced
this pull request
Apr 18, 2021
…1207) / Move test to a separate file
SchweinchenFuntik
pushed a commit
to SchweinchenFuntik/Exposed
that referenced
this pull request
Oct 23, 2021
SchweinchenFuntik
pushed a commit
to SchweinchenFuntik/Exposed
that referenced
this pull request
Oct 23, 2021
…etBrains#1207) / Move test to a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We use temporal tables to audit all the data changes.
When you do an insert, there are two special datetime2 columns (in a temporal table) declared as
GENERATED ALWAYS AS ROW START/END. These columns are mandatory.For some actions, like batch inserting, all columns need an explicit value. The columns mentioned above are automatically filled, and you cannot insert an explicit value into a
GENERATED ALWAYScolumn.You have a couple of options when inserting a new row in a temporal table like omitting the two columns or specify the DEFAULT keyword in the values list for both columns.
I've created a test that shows what we are trying to do and the suggested fix.
Other suggestions are welcome!