Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiddler types for audio and video #2083

Closed
braykov opened this issue Nov 17, 2015 · 12 comments
Closed

Add tiddler types for audio and video #2083

braykov opened this issue Nov 17, 2015 · 12 comments

Comments

@braykov
Copy link

braykov commented Nov 17, 2015

Current TiddlyWiki tiddler types contain Text and Image formats, but no audio or video.
Add these for easier embedding of music and video.

@Jermolene
Copy link
Member

Hi @braykov there are actually two separate layers at which different content types can be registered within TiddlyWiki:

  • The boot kernel defines the low level file types that TiddlyWiki understands - see them here. A type being defined here tells TiddlyWiki whether to treat it as binary or text, for example
  • The core UI defines tiddlers for each tiddler type that is to be selectable in the "type" dropdown in the edit template - they are defined here

Are all the file types that you are interested in included in the first list?

There's a strong reason to keep the size of the dropdown reasonably small; we don't want users to have to scroll to see the entire list. So I think we should restrict it to the types that are commonly used, in particular the types that are commonly worked with interactively. Users can still manually type other types.

Creating _canonical_uri tiddlers manually is tedious in any case; I'd be quite interested in adding a special new UI for creating them.

@braykov
Copy link
Author

braykov commented Nov 18, 2015

I am particularly interested in audio/mp3,mp4,ogg. They are all included in the first group.
If I had to choose a single type, that would be .ogg.

@pmario
Copy link
Member

pmario commented Nov 19, 2015

So I think we should restrict it to the types that are commonly used, in particular the types that are commonly worked with interactively. Users can still manually type other types.

.

If I had to choose a single type, that would be .ogg.

hmmm. While the .ogg format is the one, that imo fits best to the TW project, because of its "free nature", its the one, that's the least known type.

IMO .mp3 is the de-facto standard and was the matter of a lot of copyright problems. Hence the .ogg format was created. ... but according to wikipedia

In Europe mp3 is patent free and in the United States, the technology will be substantially patent-free on 31 December 2017

So there should be no problem, to implement them. .. But imo the "best audio" format discussion is a "hot" topic. If we support one extension, we basically need all of them.

@Jermolene is it possible to include additional file extensions as plugins?

This would also solve a lot of problems with other file types, that are often requested. Users can decide, what's important for them, so the dropdown list and the core can be small, and we don't need to carry things around, which we don't use often.

@tobibeer
Copy link
Contributor

Users can decide, what's important for them, so the dropdown list and the core can be small, and we don't need to carry things around, which we don't use often.

👍 => "everything is a tiddler"

@Jermolene
Copy link
Member

@Jermolene is it possible to include additional file extensions as plugins?

Yes, indeed, such a plugin would just contain tiddlers such as $:/language/Docs/Types/video/ogg, see the core types for the fields required.

@s-light
Copy link
Contributor

s-light commented Dec 17, 2019

The boot kernel defines the low level file types that TiddlyWiki understands:

new location
you can search for registerFileType or text/plain to find the code lines.


do i understand this correct that video/webm is currently not supported?
(as it is missing from the core list)
woud be nice for some local videos..

if i try it i get this message

Trying to load external content from file:///home/stefan/xyz//VID_20190422_203909.webm

If this message doesn't disappear, either the tiddler content type doesn't match the type of the external content, or you may be using a browser that doesn't support external content for wikis loaded as standalone files. See https://tiddlywiki.com/#ExternalText

@Jermolene
Copy link
Member

Hi @s-light we currently add file types to the boot kernel list as they are requested by users. It looks like we've currently got webp images, but not webm videos. It would be great if you would like to prepare a PR? See our contributing.md file for guidelines.

@s-light
Copy link
Contributor

s-light commented Dec 18, 2019

thanks @Jermolene - i will try the PR - but will need some weeks to get to it ;-)

@s-light
Copy link
Contributor

s-light commented Jan 4, 2020

@Jermolene i have created the PR.
hope that it is all fine as i have done it.

@Jermolene
Copy link
Member

Thanks @s-light

@s-light
Copy link
Contributor

s-light commented Jan 4, 2020

as i see it this issue is fixed.
from what i have seen i think all mayor file types for audio & video are supported..
so this could be closed?! @braykov

@Jermolene
Copy link
Member

I think we can indeed close it for now. Please open a new ticket to request any further new types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants