diff --git a/deps/v8/src/log-utils.cc b/deps/v8/src/log-utils.cc index 462f83f5345356..7c3de0c6ca5a6a 100644 --- a/deps/v8/src/log-utils.cc +++ b/deps/v8/src/log-utils.cc @@ -164,7 +164,7 @@ void Log::MessageBuilder::Append(String* str) { } void Log::MessageBuilder::AppendAddress(Address addr) { - Append("%p", static_cast(addr)); + Append("0x%" V8PRIxPTR, reinterpret_cast(addr)); } void Log::MessageBuilder::AppendSymbolName(Symbol* symbol) { diff --git a/deps/v8/test/cctest/test-log.cc b/deps/v8/test/cctest/test-log.cc index d18fd28d3e9cb6..e0cda1a6c6e274 100644 --- a/deps/v8/test/cctest/test-log.cc +++ b/deps/v8/test/cctest/test-log.cc @@ -376,8 +376,9 @@ TEST(LogCallbacks) { ObjMethod1_entry = *FUNCTION_ENTRYPOINT_ADDRESS(ObjMethod1_entry); #endif i::EmbeddedVector ref_data; - i::SNPrintF(ref_data, "code-creation,Callback,-2,-1,%p,1,\"method1\"", - static_cast(ObjMethod1_entry)); + i::SNPrintF(ref_data, + "code-creation,Callback,-2,-1,0x%" V8PRIxPTR ",1,\"method1\"", + reinterpret_cast(ObjMethod1_entry)); CHECK(StrNStr(log.start(), ref_data.start(), log.length())); log.Dispose(); @@ -429,8 +430,8 @@ TEST(LogAccessorCallbacks) { #endif EmbeddedVector prop1_getter_record; i::SNPrintF(prop1_getter_record, - "code-creation,Callback,-2,-1,%p,1,\"get prop1\"", - static_cast(Prop1Getter_entry)); + "code-creation,Callback,-2,-1,0x%" V8PRIxPTR ",1,\"get prop1\"", + reinterpret_cast(Prop1Getter_entry)); CHECK(StrNStr(log.start(), prop1_getter_record.start(), log.length())); Address Prop1Setter_entry = reinterpret_cast
(Prop1Setter); @@ -439,8 +440,8 @@ TEST(LogAccessorCallbacks) { #endif EmbeddedVector prop1_setter_record; i::SNPrintF(prop1_setter_record, - "code-creation,Callback,-2,-1,%p,1,\"set prop1\"", - static_cast(Prop1Setter_entry)); + "code-creation,Callback,-2,-1,0x%" V8PRIxPTR ",1,\"set prop1\"", + reinterpret_cast(Prop1Setter_entry)); CHECK(StrNStr(log.start(), prop1_setter_record.start(), log.length())); Address Prop2Getter_entry = reinterpret_cast
(Prop2Getter); @@ -449,8 +450,8 @@ TEST(LogAccessorCallbacks) { #endif EmbeddedVector prop2_getter_record; i::SNPrintF(prop2_getter_record, - "code-creation,Callback,-2,-1,%p,1,\"get prop2\"", - static_cast(Prop2Getter_entry)); + "code-creation,Callback,-2,-1,0x%" V8PRIxPTR ",1,\"get prop2\"", + reinterpret_cast(Prop2Getter_entry)); CHECK(StrNStr(log.start(), prop2_getter_record.start(), log.length())); log.Dispose(); }