Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leaks #75

Closed
MobileMon opened this issue Feb 19, 2018 · 3 comments
Closed

Memory Leaks #75

MobileMon opened this issue Feb 19, 2018 · 3 comments

Comments

@MobileMon
Copy link

Seeing a massive amount of memory leaks when using Argume in both the example project and my own personal project

In particular they occur when showing an image: agrume.showFrom(self)

In the example app if I click on "Multiple Images", then click on an image, this will trigger it

@JanGorman
Copy link
Owner

screen shot 2018-02-19 at 16 34 15

I see that it's using memory (as is to be expected) but it's also being released again. I also quickly checked the memory graph debugger but don't see any sign of cycles there.

Can you provide further details that lead you to believe that it is leaking memory?

@MobileMon
Copy link
Author

MobileMon commented Feb 19, 2018

Profile the example app and run the "leaks" program in instruments

Goto "Multiple Images" in the tableview

Click on an image to expand it

See this screenshot:

screen shot 2018-02-19 at 12 08 59 pm

@JanGorman
Copy link
Owner

JanGorman commented Feb 20, 2018

Thanks for the report. This was so minor that it's not really noticeable in the regular memory graph but I was able to reproduce it. The cells use a UIDynamicAnimator for the flick to dismiss which looks like it's retaining its referenceView. Unfortunately not documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants