Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming 'load' and 'unload' #42

Open
JamesMGreene opened this issue Mar 29, 2019 · 0 comments
Open

Consider renaming 'load' and 'unload' #42

JamesMGreene opened this issue Mar 29, 2019 · 0 comments

Comments

@JamesMGreene
Copy link
Owner

JamesMGreene commented Mar 29, 2019

Is your feature request related to a problem? Please describe.

The terminology in use for opening and closing the database does not seem ideal.

For opening:

  • new Datastore({ autoload: true }) option
  • Datastore#load method
  • Datastore#loadDatabase method (deprecated)
  • Datastore#loaded event

For closing:

  • Datastore#unload method
  • Datastore#unloaded event

Describe the solution you'd like

I would like to consider shifting it from a "load*"/"unload*" semantic to either an "open*"/"close*" or a "connect*"/"disconnect*" semantic in v3.0.0.

Describe alternatives you've considered

Not changing it.

Additional context

Although I am currently preferring the idea of "open*"/"close*", most other database libraries refer to this as connect/close since they are actually connecting via sockets vs. just loading local files... prior art. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant