Don't expose "cooling/heating allowed" settings for legacy EDA units

Fixes #105

Author: Jalle19

CHANGELOG.md

@@ -5,6 +5,7 @@
 * Upgrade `mqtt` to get rid of `async-mqtt` (https://github.com/Jalle19/eda-modbus-bridge/issues/95)
 * Remove flaky support for "PRO" unit naming scheme
 * Add rudimentary way of differentiating between different automation types
+* Disable "heating/cooling allowed" on legacy EDA units, fixes crash (https://github.com/Jalle19/eda-modbus-bridge/issues/105)
 
 ## 2.7.1
 

app/homeassistant.mjs

@@ -8,7 +8,7 @@ import {
     TOPIC_PREFIX_SETTINGS,
 } from './mqtt.mjs'
 import { createLogger } from './logger.mjs'
-import { AVAILABLE_ALARMS, createModelNameString } from './enervent.mjs'
+import { AUTOMATION_TYPE_LEGACY_EDA, AVAILABLE_ALARMS, createModelNameString } from './enervent.mjs'
 
 const logger = createLogger('homeassistant')
 
@@ -17,6 +17,7 @@ export const configureMqttDiscovery = async (modbusClient, mqttClient) => {
     // names, so it must match [a-zA-Z0-9_-].
     const modbusDeviceInformation = await getDeviceInformation(modbusClient)
     const softwareVersion = modbusDeviceInformation.softwareVersion
+    const automationType = modbusDeviceInformation.automationType
     const modelName = createModelNameString(modbusDeviceInformation)
     const deviceIdentifier = createDeviceIdentifierString(modbusDeviceInformation)
 
@@ -223,30 +224,46 @@ export const configureMqttDiscovery = async (modbusClient, mqttClient) => {
         ),
         'eco': createModeSwitchConfiguration(configurationBase, 'eco', 'Eco'),
         // Settings switches
-        'coolingAllowed': createSettingSwitchConfiguration(configurationBase, 'coolingAllowed', 'Cooling allowed'),
-        'heatingAllowed': createSettingSwitchConfiguration(configurationBase, 'heatingAllowed', 'Heating allowed'),
         'awayCoolingAllowed': createSettingSwitchConfiguration(
             configurationBase,
             'awayCoolingAllowed',
-            'Cooling allowed (away mode)'
+            'Cooling allowed (away mode)',
+            // Not supported by some units
+            { 'enabled_by_default': automationType !== AUTOMATION_TYPE_LEGACY_EDA }
         ),
         'awayHeatingAllowed': createSettingSwitchConfiguration(
             configurationBase,
             'awayHeatingAllowed',
-            'Heating allowed (away mode)'
+            'Heating allowed (away mode)',
+            // Not supported by some units
+            { 'enabled_by_default': automationType !== AUTOMATION_TYPE_LEGACY_EDA }
         ),
         'longAwayCoolingAllowed': createSettingSwitchConfiguration(
             configurationBase,
             'longAwayCoolingAllowed',
-            'Cooling allowed (long away mode)'
+            'Cooling allowed (long away mode)',
+            // Not supported by some units
+            { 'enabled_by_default': automationType !== AUTOMATION_TYPE_LEGACY_EDA }
         ),
         'longAwayHeatingAllowed': createSettingSwitchConfiguration(
             configurationBase,
             'longAwayHeatingAllowed',
-            'Heating allowed (long away mode)'
+            'Heating allowed (long away mode)',
+            // Not supported by some units
+            { 'enabled_by_default': automationType !== AUTOMATION_TYPE_LEGACY_EDA }
         ),
     }
 
+    // Optional switches depending on automation type
+    if (automationType !== AUTOMATION_TYPE_LEGACY_EDA) {
+        switchConfigurationMap = {
+            ...switchConfigurationMap,
+            // Settings switches
+            'coolingAllowed': createSettingSwitchConfiguration(configurationBase, 'coolingAllowed', 'Cooling allowed'),
+            'heatingAllowed': createSettingSwitchConfiguration(configurationBase, 'heatingAllowed', 'Heating allowed'),
+        }
+    }
+
     // Binary sensors for alarms
     let binarySensorConfigurationMap = {}
 

app/modbus.mjs

@@ -1,6 +1,7 @@
 import { Mutex } from 'async-mutex'
 import { createLogger } from './logger.mjs'
 import {
+    AUTOMATION_TYPE_LEGACY_EDA,
     AVAILABLE_ALARMS,
     AVAILABLE_FLAGS,
     AVAILABLE_SETTINGS,
@@ -178,22 +179,25 @@ export const getSettings = async (modbusClient) => {
         'temperatureTarget': parseTemperature(result.data[0]),
     }
 
-    // Heating/cooling/heat recovery enabled in normal/away/long away modes. Note that the register order is swapped
-    // when querying register 18-21 compared to 52-55.
-    result = await mutex.runExclusive(async () => tryReadCoils(modbusClient, 52, 3))
-    settings = {
-        ...settings,
-        'coolingAllowed': result.data[0],
-        'heatingAllowed': result.data[2],
-    }
+    // Heating/cooling/heat recovery enabled in normal/away/long away modes (not available on some devices).
+    // Note that the register order is swapped when querying register 18-21 compared to 52-55.
+    const deviceInformation = await getDeviceInformation(modbusClient)
+    if (deviceInformation.automationType !== AUTOMATION_TYPE_LEGACY_EDA) {
+        result = await mutex.runExclusive(async () => tryReadCoils(modbusClient, 52, 3))
+        settings = {
+            ...settings,
+            'coolingAllowed': result.data[0],
+            'heatingAllowed': result.data[2],
+        }
 
-    result = await mutex.runExclusive(async () => tryReadCoils(modbusClient, 18, 4))
-    settings = {
-        ...settings,
-        'awayCoolingAllowed': result.data[1],
-        'awayHeatingAllowed': result.data[0],
-        'longAwayCoolingAllowed': result.data[3],
-        'longAwayHeatingAllowed': result.data[2],
+        result = await mutex.runExclusive(async () => tryReadCoils(modbusClient, 18, 4))
+        settings = {
+            ...settings,
+            'awayCoolingAllowed': result.data[1],
+            'awayHeatingAllowed': result.data[0],
+            'longAwayCoolingAllowed': result.data[3],
+            'longAwayHeatingAllowed': result.data[2],
+        }
     }
 
     return settings