From bc8e1d16524dcbdac80683ebc007e22cac8406c7 Mon Sep 17 00:00:00 2001 From: Rakshit Parashar <34675136+ChillOrb@users.noreply.github.com> Date: Mon, 27 Mar 2023 18:39:34 -0700 Subject: [PATCH] Race condition detected in tests #4340 (#4344) ## Which problem is this PR solving? - Resolves #4340 ## Short description of the changes - Server in test case was not closed --------- Signed-off-by: ChillOrb --- cmd/collector/app/server/http_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/collector/app/server/http_test.go b/cmd/collector/app/server/http_test.go index bbff5f554fb..6f2742d233e 100644 --- a/cmd/collector/app/server/http_test.go +++ b/cmd/collector/app/server/http_test.go @@ -275,6 +275,7 @@ func TestStartHTTPServerParams(t *testing.T) { server, err := StartHTTPServer(params) require.NoError(t, err) + defer server.Close() assert.Equal(t, 5*time.Minute, server.IdleTimeout) assert.Equal(t, 6*time.Minute, server.ReadTimeout) assert.Equal(t, 7*time.Second, server.ReadHeaderTimeout)