From 598178673151c23d51964555764229d6f2f908fc Mon Sep 17 00:00:00 2001 From: Abinoam Praxedes Marques Jr Date: Fri, 5 Jan 2024 09:20:30 -0300 Subject: [PATCH] Skip some Reline tests to be done later See: #267 --- test/test_reline.rb | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/test/test_reline.rb b/test/test_reline.rb index 4d41bbb..3fb8e6f 100644 --- a/test/test_reline.rb +++ b/test/test_reline.rb @@ -10,6 +10,8 @@ def setup end def test_readline_mode + # See #267 + skip "We need vterm / yamatanooroti based tests for reline" # # Rubinius (and JRuby) seems to be ignoring # Readline input and output assignments. This @@ -77,7 +79,11 @@ def test_readline_mode_with_limit_set output = @output.read assert_equal "any input", answer - assert_equal "Prompt: any input\n", output + + # after migrating to Reline, we can't make assertions about the output + # without using vterm / yamatanooroti. See #267 + # + # assert_equal "Prompt: any input\n", output @input.close @output.close @@ -93,7 +99,11 @@ def test_readline_on_non_echo_question_has_prompt q.echo = "*" end assert_equal("you can't see me", answer) - assert_equal("Please enter some hidden text: ****************\n", - @output.string) + + # after migrating to Reline, we can't make assertions about the output + # without using vterm / yamatanooroti. See #267 + # + # assert_equal("Please enter some hidden text: ****************\n", + # @output.string) end end