-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for mapl #1071
Fix for mapl #1071
Conversation
Would you mind adding the same lines for Acorn? 🙏 |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@climbfuji I think to me it would make sense to merge these changes into release/1.7.0 but not develop.
Yes, and that makes life a lot easier. I am in the process of merging the release down into develop. Since this PR here isn't supposed to go into develop, I can merge that now and simply retag the release w/o modifying my PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also reminds me that (later on develop) we should switch to require
wherever we really know what we want and need, and try to remove any other specs that we specify (because of historical reasons etc) and that aren't really needed.
All done! Thanks @RatkoVasic-NOAA and @AlexanderRichert-NOAA |
Summary
With Intel compiler newer than 2021.7 mapl was having problems with pflogger and extdata2g
Added lines in packages.yaml for machines: Orion, Hercules, Gaea and Derecho:
mapl:
require: '@2.40.3 ~pflogger ~extdata2g'
Testing
Tested on Orion, Hercules, Gaea and Derecho machines.
Systems affected
Orion, Hercules, Gaea and Derecho
Issue(s) addressed
This solves issue #1070
Checklist