Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mapl #1071

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix for mapl #1071

merged 2 commits into from
Apr 11, 2024

Conversation

RatkoVasic-NOAA
Copy link
Collaborator

Summary

With Intel compiler newer than 2021.7 mapl was having problems with pflogger and extdata2g
Added lines in packages.yaml for machines: Orion, Hercules, Gaea and Derecho:
mapl:
require: '@2.40.3 ~pflogger ~extdata2g'

Testing

Tested on Orion, Hercules, Gaea and Derecho machines.

Systems affected

Orion, Hercules, Gaea and Derecho

Issue(s) addressed

This solves issue #1070

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@AlexanderRichert-NOAA
Copy link
Collaborator

Would you mind adding the same lines for Acorn? 🙏

@RatkoVasic-NOAA
Copy link
Collaborator Author

Would you mind adding the same lines for Acorn? 🙏

Done

Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climbfuji I think to me it would make sense to merge these changes into release/1.7.0 but not develop.

@climbfuji
Copy link
Collaborator

@climbfuji I think to me it would make sense to merge these changes into release/1.7.0 but not develop.

Yes, and that makes life a lot easier. I am in the process of merging the release down into develop. Since this PR here isn't supposed to go into develop, I can merge that now and simply retag the release w/o modifying my PRs.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also reminds me that (later on develop) we should switch to require wherever we really know what we want and need, and try to remove any other specs that we specify (because of historical reasons etc) and that aren't really needed.

@climbfuji climbfuji merged commit 74a37de into JCSDA:release/1.7.0 Apr 11, 2024
6 checks passed
@climbfuji
Copy link
Collaborator

All done! Thanks @RatkoVasic-NOAA and @AlexanderRichert-NOAA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants