Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the forward flag in the data to determine negative viewing angles #1608

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

use the forward flag in the data to determine negative viewing angles #1608

wants to merge 9 commits into from

Conversation

BenjaminRuston
Copy link
Collaborator

Description

Use the flag in the TROPICS data to determine which viewing angles are assigned negative values

Issue(s) addressed

Resolves #1607

Impact

The TROPICS viewing angle can be negative and which side of the scan this occurs is triggered by the foreward flag

Checklist

  • I have performed a self-review of my own code
  • I have run the unit tests before creating the PR

ashley314
ashley314 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ashley314 ashley314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me. Although I did not find a date where the view angle was or needed to be negative.

@BenjaminRuston
Copy link
Collaborator Author

@fcvdb or @fabiolrdiniz this needs another review too is another step for tropics assimilation

@BenjaminRuston
Copy link
Collaborator Author

this PR show how to use the bit8 (i_forward) which shows spins direction of sensor to assign negative viewing angles

@BenjaminRuston
Copy link
Collaborator Author

from Vince Leslie MITLL:
image

@BenjaminRuston
Copy link
Collaborator Author

BenjaminRuston commented Feb 25, 2025 •
edited
Loading

here's the latest update from Vince Leslie (MITLL)

So new algorithm for scan angle for the TROPICS NRT NOAA BUFR:

Multiply the scan angles for spots 1 to 40 by -1.
For spot 41:  (new spot 40 scan angle + spot 42 scan angle)/2

Spot 42 is blue, Spot 41 is orange, and spot 40 is yellow.
image

@fabiolrdiniz
Copy link
Contributor

The unit test fails because of the expected 200% difference in the sensorViewAngle due to the flip to negative values. I believe we only need to update the reference file.

@fabiolrdiniz fabiolrdiniz added the OBS OBS processing, UFO label Feb 26, 2025
@BenjaminRuston
Copy link
Collaborator Author

think this is working correctly @fabiolrdiniz
image

however, I may need to change the ctest testinput file as the scan positions and view angles do not seem correct so think when it was reduced something odd happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashley314 ashley314 ashley314 approved these changes

@fcvdb fcvdb Awaiting requested review from fcvdb

@smaticka smaticka Awaiting requested review from smaticka

@fabiolrdiniz fabiolrdiniz Awaiting requested review from fabiolrdiniz

@emilyhcliu emilyhcliu Awaiting requested review from emilyhcliu

At least 2 approving reviews are required to merge this pull request.

Assignees

@BenjaminRuston BenjaminRuston

Labels
OBS OBS processing, UFO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tropics use flag to set negative viewing angle
5 participants
@BenjaminRuston @fabiolrdiniz @ashley314 @fcvdb @smaticka