heading-smaller, heading-bigger, heading-1, 2, 3 - using wrong css class?

[jarrodbell]

Seems all these icons are using fa-header which doesn't exist in FontAwesome.
Should they also have fa-heading?

Displaying those buttons by default will result in the FontAwesome 'missing icon question mark' displaying instead.

On a similar note, the "H1, H2, H3" is currently added using css :after, but FontAwesome 5 has inbuilt support for fa-h1, etc, which looks cleaner.

[Ionaru]

Unfortunately fa-h1, fa-h2 and fa-h3 are only available in FontAwesome Pro, I'd like to keep the default icons compatible with the free version of FontAwesome.

(Seems like the other icon classes on that button: fa-header-x, fa-header-1, fa-header-bigger, etc. do not work at all)

I am working on a complete rewrite of the project that will solve these icon issues, but that's a long way from being finished.

Right now I can change the code so the icon class has fa-heading, which would make them the same as the regular heading button. Alternatively you can set your own icon classes using the configuration.
Let me know which solution you prefer.

[jarrodbell]

Ahh yes didn't notice H1/2/3 are Pro only. So just adding fa-heading by default for smaller/bigger will do enough to fix a completely missing icon.

Maybe add fa-sm or fa-lg to show the heading icon in smaller or larger size in the toolbar by default?

[Ionaru]

Sounds good to me