Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builtins] Make all builtins strict #6523

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

effectfully
Copy link
Contributor

I was investigating a weird behavior of a test and this is where it led me to. This PR is gonna be blocked by broken benchmarking though, but we really should make builtins strict, because laziness only reduces the quality of tests.

@effectfully
Copy link
Contributor Author

/benchmark validation

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'validation' on '6e469a346b' (base) and '2fb2d22dcb' (PR)

Results table
Script 6e469a3 2fb2d22 Change
auction_1-1 256.2 μs 258.6 μs +0.9%
auction_1-2 914.3 μs 614.8 μs -32.8%
auction_1-3 903.3 μs 620.4 μs -31.3%
auction_1-4 325.4 μs 228.3 μs -29.8%
auction_2-1 257.0 μs 177.9 μs -30.8%
auction_2-2 919.9 μs 628.5 μs -31.7%
auction_2-3 841.1 μs 822.8 μs -2.2%
auction_2-4 632.8 μs 623.1 μs -1.5%
auction_2-5 231.2 μs 229.1 μs -0.9%
crowdfunding-success-1 208.7 μs 207.6 μs -0.5%
crowdfunding-success-2 293.4 μs 207.3 μs -29.3%
crowdfunding-success-3 297.3 μs 211.6 μs -28.8%
currency-1 354.1 μs 244.4 μs -31.0%
escrow-redeem_1-1 493.0 μs 349.9 μs -29.0%
escrow-redeem_1-2 494.9 μs 491.0 μs -0.8%
escrow-redeem_2-1 582.8 μs 578.8 μs -0.7%
escrow-redeem_2-2 404.9 μs 578.3 μs +42.8%
escrow-redeem_2-3 419.5 μs 580.4 μs +38.4%
escrow-refund-1 156.1 μs 222.3 μs +42.4%
future-increase-margin-1 357.4 μs 352.3 μs -1.4%
future-increase-margin-2 578.7 μs 760.3 μs +31.4%
future-increase-margin-3 768.6 μs 704.2 μs -8.4%
future-increase-margin-4 695.4 μs 548.2 μs -21.2%
future-increase-margin-5 1.158 ms 1.160 ms +0.2%
future-pay-out-1 353.8 μs 350.7 μs -0.9%
future-pay-out-2 765.5 μs 758.4 μs -0.9%
future-pay-out-3 766.5 μs 759.4 μs -0.9%
future-pay-out-4 794.2 μs 850.6 μs +7.1%
future-settle-early-1 249.6 μs 244.9 μs -1.9%
future-settle-early-2 541.5 μs 531.5 μs -1.8%
future-settle-early-3 543.0 μs 532.6 μs -1.9%
future-settle-early-4 612.7 μs 868.6 μs +41.8%
game-sm-success_1-1 390.4 μs 537.3 μs +37.6%
game-sm-success_1-2 200.7 μs 195.3 μs -2.7%
game-sm-success_1-3 640.7 μs 831.9 μs +29.8%
game-sm-success_1-4 232.6 μs 330.2 μs +42.0%
game-sm-success_2-1 389.1 μs 548.7 μs +41.0%
game-sm-success_2-2 200.8 μs 284.7 μs +41.8%
game-sm-success_2-3 642.7 μs 906.9 μs +41.1%
game-sm-success_2-4 232.7 μs 329.9 μs +41.8%
game-sm-success_2-5 645.0 μs 908.5 μs +40.9%
game-sm-success_2-6 232.4 μs 329.2 μs +41.7%
multisig-sm-1 532.9 μs 558.7 μs +4.8%
multisig-sm-2 381.7 μs 543.9 μs +42.5%
multisig-sm-3 393.2 μs 552.0 μs +40.4%
multisig-sm-4 395.3 μs 555.8 μs +40.6%
multisig-sm-5 760.4 μs 648.3 μs -14.7%
multisig-sm-6 565.7 μs 560.7 μs -0.9%
multisig-sm-7 548.0 μs 543.5 μs -0.8%
multisig-sm-8 560.1 μs 554.5 μs -1.0%
multisig-sm-9 559.2 μs 557.3 μs -0.3%
multisig-sm-10 790.5 μs 785.8 μs -0.6%
ping-pong-1 470.1 μs 468.0 μs -0.4%
ping-pong-2 469.2 μs 467.7 μs -0.3%
ping-pong_2-1 284.5 μs 282.3 μs -0.8%
prism-1 240.3 μs 239.5 μs -0.3%
prism-2 408.2 μs 587.2 μs +43.9%
prism-3 369.4 μs 520.6 μs +40.9%
pubkey-1 143.1 μs 201.4 μs +40.7%
stablecoin_1-1 910.4 μs 1.271 ms +39.6%
stablecoin_1-2 195.9 μs 278.9 μs +42.4%
stablecoin_1-3 1.041 ms 1.464 ms +40.6%
stablecoin_1-4 297.2 μs 293.8 μs -1.1%
stablecoin_1-5 1.895 ms 1.880 ms -0.8%
stablecoin_1-6 255.1 μs 363.6 μs +42.5%
stablecoin_2-1 911.4 μs 1.271 ms +39.5%
stablecoin_2-2 195.7 μs 279.1 μs +42.6%
stablecoin_2-3 1.042 ms 1.463 ms +40.4%
stablecoin_2-4 207.8 μs 293.8 μs +41.4%
token-account-1 191.4 μs 187.6 μs -2.0%
token-account-2 340.9 μs 335.7 μs -1.5%
uniswap-1 419.9 μs 414.0 μs -1.4%
uniswap-2 227.3 μs 224.6 μs -1.2%
uniswap-3 1.762 ms 1.751 ms -0.6%
uniswap-4 359.1 μs 332.8 μs -7.3%
uniswap-5 1.157 ms 1.146 ms -1.0%
uniswap-6 339.3 μs 316.8 μs -6.6%
vesting-1 347.7 μs 350.2 μs +0.7%
6e469a3 2fb2d22 Change
TOTAL 40.95 ms 44.04 ms +7.6%

@effectfully
Copy link
Contributor Author

The benchmarking machine is still sick.

@effectfully
Copy link
Contributor Author

/benchmark validation

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'validation' on '9b4e76a9a' (base) and '0a644b5af' (PR)

Results table
Script 9b4e76a 0a644b5 Change
auction_1-1 254.8 μs 257.3 μs +1.0%
auction_1-2 908.7 μs 910.4 μs +0.2%
auction_1-3 899.8 μs 906.4 μs +0.7%
auction_1-4 329.1 μs 331.5 μs +0.7%
auction_2-1 254.5 μs 257.1 μs +1.0%
auction_2-2 913.5 μs 909.8 μs -0.4%
auction_2-3 1.184 ms 1.188 ms +0.3%
auction_2-4 900.1 μs 900.8 μs +0.1%
auction_2-5 329.7 μs 332.9 μs +1.0%
crowdfunding-success-1 297.5 μs 299.2 μs +0.6%
crowdfunding-success-2 296.6 μs 299.0 μs +0.8%
crowdfunding-success-3 297.6 μs 299.0 μs +0.5%
currency-1 356.3 μs 357.4 μs +0.3%
escrow-redeem_1-1 496.5 μs 498.1 μs +0.3%
escrow-redeem_1-2 496.7 μs 503.3 μs +1.3%
escrow-redeem_2-1 582.3 μs 582.5 μs +0.0%
escrow-redeem_2-2 397.3 μs 581.5 μs +46.4%
escrow-redeem_2-3 407.6 μs 577.9 μs +41.8%
escrow-refund-1 155.9 μs 222.3 μs +42.6%
future-increase-margin-1 251.5 μs 360.2 μs +43.2%
future-increase-margin-2 539.0 μs 765.5 μs +42.0%
future-increase-margin-3 542.4 μs 774.7 μs +42.8%
future-increase-margin-4 494.4 μs 694.6 μs +40.5%
future-increase-margin-5 812.3 μs 1.153 ms +41.9%
future-pay-out-1 251.4 μs 356.4 μs +41.8%
future-pay-out-2 540.4 μs 778.8 μs +44.1%
future-pay-out-3 777.8 μs 766.0 μs -1.5%
future-pay-out-4 1.153 ms 1.153 ms 0.0%
future-settle-early-1 356.7 μs 356.3 μs -0.1%
future-settle-early-2 765.7 μs 765.1 μs -0.1%
future-settle-early-3 764.5 μs 768.2 μs +0.5%
future-settle-early-4 858.2 μs 859.9 μs +0.2%
game-sm-success_1-1 551.5 μs 554.8 μs +0.6%
game-sm-success_1-2 283.9 μs 287.3 μs +1.2%
game-sm-success_1-3 905.8 μs 912.1 μs +0.7%
game-sm-success_1-4 331.6 μs 333.8 μs +0.7%
game-sm-success_2-1 403.9 μs 557.1 μs +37.9%
game-sm-success_2-2 241.9 μs 286.7 μs +18.5%
game-sm-success_2-3 690.6 μs 913.2 μs +32.2%
game-sm-success_2-4 274.8 μs 268.1 μs -2.4%
game-sm-success_2-5 910.0 μs 634.7 μs -30.3%
game-sm-success_2-6 300.9 μs 232.8 μs -22.6%
multisig-sm-1 563.4 μs 392.9 μs -30.3%
multisig-sm-2 546.1 μs 382.3 μs -30.0%
multisig-sm-3 384.9 μs 387.3 μs +0.6%
multisig-sm-4 470.1 μs 393.0 μs -16.4%
multisig-sm-5 795.6 μs 553.4 μs -30.4%
multisig-sm-6 558.3 μs 393.3 μs -29.6%
multisig-sm-7 546.6 μs 382.8 μs -30.0%
multisig-sm-8 391.0 μs 389.5 μs -0.4%
multisig-sm-9 392.9 μs 395.2 μs +0.6%
multisig-sm-10 557.8 μs 557.7 μs -0.0%
ping-pong-1 329.9 μs 327.9 μs -0.6%
ping-pong-2 328.1 μs 464.0 μs +41.4%
ping-pong_2-1 201.2 μs 286.4 μs +42.3%
prism-1 169.3 μs 227.7 μs +34.5%
prism-2 413.2 μs 407.1 μs -1.5%
prism-3 370.7 μs 382.5 μs +3.2%
pubkey-1 142.0 μs 142.5 μs +0.4%
stablecoin_1-1 907.9 μs 1.283 ms +41.3%
stablecoin_1-2 195.8 μs 281.4 μs +43.7%
stablecoin_1-3 1.046 ms 1.483 ms +41.8%
stablecoin_1-4 209.1 μs 302.9 μs +44.9%
stablecoin_1-5 1.344 ms 1.903 ms +41.6%
stablecoin_1-6 258.4 μs 367.7 μs +42.3%
stablecoin_2-1 907.5 μs 1.282 ms +41.3%
stablecoin_2-2 196.1 μs 280.7 μs +43.1%
stablecoin_2-3 1.130 ms 1.025 ms -9.3%
stablecoin_2-4 295.9 μs 226.1 μs -23.6%
token-account-1 186.3 μs 267.9 μs +43.8%
token-account-2 335.6 μs 477.5 μs +42.3%
uniswap-1 417.0 μs 588.4 μs +41.1%
uniswap-2 220.6 μs 314.6 μs +42.6%
uniswap-3 1.776 ms 2.491 ms +40.3%
uniswap-4 336.2 μs 486.5 μs +44.7%
uniswap-5 1.161 ms 1.649 ms +42.0%
uniswap-6 318.9 μs 459.4 μs +44.1%
vesting-1 347.5 μs 495.5 μs +42.6%
9b4e76a 0a644b5 Change
TOTAL 41.51 ms 46.88 ms +12.9%

…to effectfully/builtins/make-all-builtins-strict
@effectfully effectfully force-pushed the effectfully/builtins/make-all-builtins-strict branch from 0a644b5 to 3b689ae Compare November 7, 2024 11:57
@effectfully
Copy link
Contributor Author

/benchmark validation

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Click here to check the status of your benchmark.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Comparing benchmark results of 'validation' on '2411c01a8' (base) and '3b689ae88' (PR)

Results table
Script 2411c01 3b689ae Change
auction_1-1 178.9 μs 185.6 μs +3.7%
auction_1-2 639.7 μs 664.4 μs +3.9%
auction_1-3 634.2 μs 661.8 μs +4.4%
auction_1-4 241.2 μs 240.4 μs -0.3%
auction_2-1 186.6 μs 186.0 μs -0.3%
auction_2-2 661.4 μs 669.4 μs +1.2%
auction_2-3 872.7 μs 872.7 μs 0.0%
auction_2-4 658.8 μs 660.6 μs +0.3%
auction_2-5 241.1 μs 240.4 μs -0.3%
crowdfunding-success-1 218.6 μs 223.7 μs +2.3%
crowdfunding-success-2 219.4 μs 218.3 μs -0.5%
crowdfunding-success-3 219.4 μs 218.3 μs -0.5%
currency-1 353.9 μs 260.3 μs -26.4%
escrow-redeem_1-1 499.7 μs 364.1 μs -27.1%
escrow-redeem_1-2 498.7 μs 363.1 μs -27.2%
escrow-redeem_2-1 583.4 μs 426.3 μs -26.9%
escrow-redeem_2-2 582.5 μs 425.7 μs -26.9%
escrow-redeem_2-3 584.2 μs 426.4 μs -27.0%
escrow-refund-1 224.1 μs 161.0 μs -28.2%
future-increase-margin-1 355.5 μs 260.5 μs -26.7%
future-increase-margin-2 767.9 μs 560.1 μs -27.1%
future-increase-margin-3 768.8 μs 559.5 μs -27.2%
future-increase-margin-4 691.6 μs 505.8 μs -26.9%
future-increase-margin-5 1.102 ms 850.1 μs -22.9%
future-pay-out-1 260.5 μs 260.1 μs -0.2%
future-pay-out-2 563.6 μs 559.5 μs -0.7%
future-pay-out-3 558.9 μs 568.2 μs +1.7%
future-pay-out-4 842.0 μs 846.7 μs +0.6%
future-settle-early-1 260.8 μs 260.0 μs -0.3%
future-settle-early-2 562.7 μs 636.8 μs +13.2%
future-settle-early-3 560.1 μs 534.1 μs -4.6%
future-settle-early-4 628.9 μs 806.3 μs +28.2%
game-sm-success_1-1 493.6 μs 548.1 μs +11.0%
game-sm-success_1-2 202.3 μs 209.5 μs +3.6%
game-sm-success_1-3 641.6 μs 663.3 μs +3.4%
game-sm-success_1-4 236.6 μs 242.8 μs +2.6%
game-sm-success_2-1 391.3 μs 402.0 μs +2.7%
game-sm-success_2-2 206.1 μs 208.0 μs +0.9%
game-sm-success_2-3 657.9 μs 665.5 μs +1.2%
game-sm-success_2-4 244.9 μs 243.2 μs -0.7%
game-sm-success_2-5 759.6 μs 663.2 μs -12.7%
game-sm-success_2-6 235.6 μs 243.4 μs +3.3%
multisig-sm-1 397.4 μs 408.3 μs +2.7%
multisig-sm-2 386.8 μs 398.4 μs +3.0%
multisig-sm-3 391.1 μs 402.9 μs +3.0%
multisig-sm-4 412.9 μs 404.9 μs -1.9%
multisig-sm-5 577.4 μs 575.7 μs -0.3%
multisig-sm-6 410.4 μs 406.9 μs -0.9%
multisig-sm-7 400.4 μs 396.8 μs -0.9%
multisig-sm-8 559.9 μs 401.8 μs -28.2%
multisig-sm-9 559.6 μs 405.5 μs -27.5%
multisig-sm-10 791.7 μs 575.5 μs -27.3%
ping-pong-1 427.2 μs 345.0 μs -19.2%
ping-pong-2 339.4 μs 341.4 μs +0.6%
ping-pong_2-1 208.1 μs 209.0 μs +0.4%
prism-1 177.0 μs 176.5 μs -0.3%
prism-2 428.4 μs 431.2 μs +0.7%
prism-3 384.4 μs 526.9 μs +37.1%
pubkey-1 148.1 μs 190.0 μs +28.3%
stablecoin_1-1 940.2 μs 1.274 ms +35.5%
stablecoin_1-2 205.2 μs 201.6 μs -1.8%
stablecoin_1-3 1.084 ms 1.094 ms +0.9%
stablecoin_1-4 218.2 μs 216.0 μs -1.0%
stablecoin_1-5 1.399 ms 1.395 ms -0.3%
stablecoin_1-6 270.0 μs 267.4 μs -1.0%
stablecoin_2-1 939.7 μs 937.0 μs -0.3%
stablecoin_2-2 205.0 μs 203.5 μs -0.7%
stablecoin_2-3 1.084 ms 1.080 ms -0.4%
stablecoin_2-4 218.3 μs 216.5 μs -0.8%
token-account-1 216.8 μs 194.8 μs -10.1%
token-account-2 335.8 μs 347.1 μs +3.4%
uniswap-1 413.0 μs 430.0 μs +4.1%
uniswap-2 221.9 μs 230.0 μs +3.7%
uniswap-3 1.768 ms 1.834 ms +3.7%
uniswap-4 344.1 μs 349.9 μs +1.7%
uniswap-5 1.161 ms 1.204 ms +3.7%
uniswap-6 382.0 μs 332.2 μs -13.0%
vesting-1 492.9 μs 360.9 μs -26.8%
2411c01 3b689ae Change
TOTAL 39.19 ms 37.53 ms -4.2%

…to effectfully/builtins/make-all-builtins-strict
@effectfully
Copy link
Contributor Author

/benchmark validation

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'validation' on '9b27bf75f1' (base) and '1cfcd3e5ec' (PR)

Results table
Script 9b27bf7 1cfcd3e Change
auction_1-1 255.8 μs 255.8 μs 0.0%
auction_1-2 911.6 μs 917.8 μs +0.7%
auction_1-3 903.3 μs 916.0 μs +1.4%
auction_1-4 331.4 μs 330.6 μs -0.2%
auction_2-1 256.2 μs 256.2 μs 0.0%
auction_2-2 912.2 μs 916.8 μs +0.5%
auction_2-3 1.194 ms 1.197 ms +0.3%
auction_2-4 905.2 μs 911.1 μs +0.7%
auction_2-5 330.8 μs 331.8 μs +0.3%
crowdfunding-success-1 301.8 μs 299.5 μs -0.8%
crowdfunding-success-2 303.9 μs 302.6 μs -0.4%
crowdfunding-success-3 303.6 μs 302.6 μs -0.3%
currency-1 359.8 μs 360.5 μs +0.2%
escrow-redeem_1-1 499.2 μs 498.5 μs -0.1%
escrow-redeem_1-2 505.2 μs 504.0 μs -0.2%
escrow-redeem_2-1 588.4 μs 588.9 μs +0.1%
escrow-redeem_2-2 587.4 μs 588.3 μs +0.2%
escrow-redeem_2-3 588.9 μs 589.4 μs +0.1%
escrow-refund-1 225.6 μs 223.2 μs -1.1%
future-increase-margin-1 360.5 μs 361.0 μs +0.1%
future-increase-margin-2 770.5 μs 772.5 μs +0.3%
future-increase-margin-3 768.7 μs 769.6 μs +0.1%
future-increase-margin-4 697.8 μs 696.2 μs -0.2%
future-increase-margin-5 1.159 ms 1.155 ms -0.3%
future-pay-out-1 359.2 μs 360.9 μs +0.5%
future-pay-out-2 765.8 μs 773.9 μs +1.1%
future-pay-out-3 767.0 μs 769.7 μs +0.4%
future-pay-out-4 1.151 ms 1.151 ms 0.0%
future-settle-early-1 359.6 μs 360.3 μs +0.2%
future-settle-early-2 771.7 μs 770.5 μs -0.2%
future-settle-early-3 769.0 μs 769.1 μs +0.0%
future-settle-early-4 864.2 μs 869.5 μs +0.6%
game-sm-success_1-1 555.6 μs 555.9 μs +0.1%
game-sm-success_1-2 289.4 μs 287.5 μs -0.7%
game-sm-success_1-3 910.9 μs 911.1 μs +0.0%
game-sm-success_1-4 335.5 μs 334.5 μs -0.3%
game-sm-success_2-1 555.6 μs 556.7 μs +0.2%
game-sm-success_2-2 291.1 μs 286.5 μs -1.6%
game-sm-success_2-3 910.8 μs 912.4 μs +0.2%
game-sm-success_2-4 336.9 μs 335.0 μs -0.6%
game-sm-success_2-5 909.9 μs 911.4 μs +0.2%
game-sm-success_2-6 336.4 μs 334.2 μs -0.7%
multisig-sm-1 562.9 μs 559.3 μs -0.6%
multisig-sm-2 551.5 μs 546.8 μs -0.9%
multisig-sm-3 555.9 μs 552.6 μs -0.6%
multisig-sm-4 561.1 μs 559.1 μs -0.4%
multisig-sm-5 793.4 μs 792.6 μs -0.1%
multisig-sm-6 561.5 μs 557.8 μs -0.7%
multisig-sm-7 549.4 μs 547.5 μs -0.3%
multisig-sm-8 553.5 μs 552.3 μs -0.2%
multisig-sm-9 561.4 μs 557.5 μs -0.7%
multisig-sm-10 792.4 μs 792.0 μs -0.1%
ping-pong-1 464.6 μs 468.0 μs +0.7%
ping-pong-2 466.3 μs 468.9 μs +0.6%
ping-pong_2-1 286.3 μs 286.6 μs +0.1%
prism-1 243.9 μs 242.8 μs -0.5%
prism-2 588.6 μs 588.2 μs -0.1%
prism-3 530.0 μs 531.5 μs +0.3%
pubkey-1 203.9 μs 202.5 μs -0.7%
stablecoin_1-1 1.284 ms 1.300 ms +1.2%
stablecoin_1-2 282.4 μs 280.3 μs -0.7%
stablecoin_1-3 1.486 ms 1.507 ms +1.4%
stablecoin_1-4 301.0 μs 299.7 μs -0.4%
stablecoin_1-5 1.913 ms 1.937 ms +1.3%
stablecoin_1-6 371.0 μs 369.4 μs -0.4%
stablecoin_2-1 1.283 ms 1.289 ms +0.5%
stablecoin_2-2 282.1 μs 281.2 μs -0.3%
stablecoin_2-3 1.486 ms 1.495 ms +0.6%
stablecoin_2-4 300.7 μs 297.8 μs -1.0%
token-account-1 268.9 μs 267.7 μs -0.4%
token-account-2 477.2 μs 478.1 μs +0.2%
uniswap-1 589.2 μs 591.0 μs +0.3%
uniswap-2 315.3 μs 316.9 μs +0.5%
uniswap-3 2.514 ms 2.518 ms +0.2%
uniswap-4 485.2 μs 481.8 μs -0.7%
uniswap-5 1.650 ms 1.652 ms +0.1%
uniswap-6 458.5 μs 457.2 μs -0.3%
vesting-1 494.6 μs 496.0 μs +0.3%
9b27bf7 1cfcd3e Change
TOTAL 50.33 ms 50.42 ms +0.2%

…to effectfully/builtins/make-all-builtins-strict
@effectfully
Copy link
Contributor Author

/benchmark nofib

@effectfully
Copy link
Contributor Author

/benchmark lists

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'nofib' on '1d9a758c1f' (base) and '6169ff7b1b' (PR)

Results table
Script 1d9a758 6169ff7 Change
clausify/formula1 4.386 ms 4.449 ms +1.4%
clausify/formula2 5.849 ms 5.951 ms +1.7%
clausify/formula3 16.02 ms 16.27 ms +1.6%
clausify/formula4 36.61 ms 37.25 ms +1.7%
clausify/formula5 77.34 ms 78.86 ms +2.0%
knights/4x4 25.39 ms 25.66 ms +1.1%
knights/6x6 66.88 ms 67.68 ms +1.2%
knights/8x8 117.4 ms 119.4 ms +1.7%
primetest/05digits 15.44 ms 14.84 ms -3.9%
primetest/10digits 29.91 ms 29.02 ms -3.0%
primetest/30digits 92.81 ms 90.14 ms -2.9%
primetest/50digits 153.8 ms 148.9 ms -3.2%
queens4x4/bt 7.696 ms 7.749 ms +0.7%
queens4x4/bm 9.693 ms 9.829 ms +1.4%
queens4x4/bjbt1 9.327 ms 9.393 ms +0.7%
queens4x4/bjbt2 8.741 ms 8.803 ms +0.7%
queens4x4/fc 19.65 ms 19.79 ms +0.7%
queens5x5/bt 104.6 ms 105.4 ms +0.8%
queens5x5/bm 108.9 ms 110.2 ms +1.2%
queens5x5/bjbt1 122.2 ms 123.2 ms +0.8%
queens5x5/bjbt2 118.4 ms 119.3 ms +0.8%
queens5x5/fc 249.7 ms 252.6 ms +1.2%
1d9a758 6169ff7 Change
TOTAL 1.401 s 1.405 s +0.3%

Copy link
Contributor

Click here to check the status of your benchmark.

@effectfully
Copy link
Contributor Author

/benchmark nofib

@effectfully
Copy link
Contributor Author

/benchmark lists

Copy link
Contributor

Comparing benchmark results of 'lists' on '1d9a758c1f' (base) and '6169ff7b1b' (PR)

Results table
Script 1d9a758 6169ff7 Change
sort/ghcSort/50 343.3 μs 330.2 μs -3.8%
sort/ghcSort/100 803.8 μs 775.4 μs -3.5%
sort/ghcSort/150 1.390 ms 1.343 ms -3.4%
sort/ghcSort/200 1.873 ms 1.809 ms -3.4%
sort/ghcSort/250 2.419 ms 2.340 ms -3.3%
sort/ghcSort/300 3.190 ms 3.089 ms -3.2%
sort/insertionSort/50 1.183 ms 1.117 ms -5.6%
sort/insertionSort/100 4.719 ms 4.454 ms -5.6%
sort/insertionSort/150 10.66 ms 10.04 ms -5.8%
sort/insertionSort/200 18.94 ms 17.94 ms -5.3%
sort/insertionSort/250 29.83 ms 28.18 ms -5.5%
sort/insertionSort/300 43.11 ms 40.58 ms -5.9%
sort/mergeSort/50 1.012 ms 976.0 μs -3.6%
sort/mergeSort/100 2.330 ms 2.242 ms -3.8%
sort/mergeSort/150 3.756 ms 3.609 ms -3.9%
sort/mergeSort/200 5.273 ms 5.090 ms -3.5%
sort/mergeSort/250 6.903 ms 6.644 ms -3.8%
sort/mergeSort/300 8.432 ms 8.120 ms -3.7%
sort/quickSort/50 2.825 ms 2.742 ms -2.9%
sort/quickSort/100 11.38 ms 11.10 ms -2.5%
sort/quickSort/150 25.69 ms 24.89 ms -3.1%
sort/quickSort/200 45.46 ms 44.18 ms -2.8%
sort/quickSort/250 71.04 ms 68.85 ms -3.1%
sort/quickSort/300 102.9 ms 99.77 ms -3.0%
sum/compiled-from-Haskell/sum-right-builtin/100 131.3 μs 128.4 μs -2.2%
sum/compiled-from-Haskell/sum-right-builtin/500 677.2 μs 672.4 μs -0.7%
sum/compiled-from-Haskell/sum-right-builtin/1000 1.446 ms 1.434 ms -0.8%
sum/compiled-from-Haskell/sum-right-builtin/2500 4.302 ms 4.286 ms -0.4%
sum/compiled-from-Haskell/sum-right-builtin/5000 9.215 ms 9.180 ms -0.4%
sum/compiled-from-Haskell/sum-right-Scott/100 87.77 μs 87.98 μs +0.2%
sum/compiled-from-Haskell/sum-right-Scott/500 465.4 μs 468.4 μs +0.6%
sum/compiled-from-Haskell/sum-right-Scott/1000 1.041 ms 1.046 ms +0.5%
sum/compiled-from-Haskell/sum-right-Scott/2500 3.264 ms 3.290 ms +0.8%
sum/compiled-from-Haskell/sum-right-Scott/5000 7.252 ms 7.287 ms +0.5%
sum/compiled-from-Haskell/sum-right-data/100 412.9 μs 397.3 μs -3.8%
sum/compiled-from-Haskell/sum-right-data/500 2.282 ms 2.206 ms -3.3%
sum/compiled-from-Haskell/sum-right-data/1000 5.027 ms 4.889 ms -2.7%
sum/compiled-from-Haskell/sum-right-data/2500 13.38 ms 13.06 ms -2.4%
sum/compiled-from-Haskell/sum-right-data/5000 27.68 ms 27.09 ms -2.1%
sum/compiled-from-Haskell/sum-left-builtin/100 128.5 μs 127.5 μs -0.8%
sum/compiled-from-Haskell/sum-left-builtin/500 670.5 μs 662.8 μs -1.1%
sum/compiled-from-Haskell/sum-left-builtin/1000 1.427 ms 1.415 ms -0.8%
sum/compiled-from-Haskell/sum-left-builtin/2500 4.272 ms 4.238 ms -0.8%
sum/compiled-from-Haskell/sum-left-builtin/5000 9.225 ms 9.193 ms -0.3%
sum/compiled-from-Haskell/sum-left-Scott/100 86.54 μs 86.66 μs +0.1%
sum/compiled-from-Haskell/sum-left-Scott/500 457.5 μs 455.6 μs -0.4%
sum/compiled-from-Haskell/sum-left-Scott/1000 984.7 μs 983.7 μs -0.1%
sum/compiled-from-Haskell/sum-left-Scott/2500 3.170 ms 3.155 ms -0.5%
sum/compiled-from-Haskell/sum-left-Scott/5000 7.205 ms 7.175 ms -0.4%
sum/compiled-from-Haskell/sum-left-data/100 424.9 μs 402.7 μs -5.2%
sum/compiled-from-Haskell/sum-left-data/500 2.350 ms 2.238 ms -4.8%
sum/compiled-from-Haskell/sum-left-data/1000 5.198 ms 4.970 ms -4.4%
sum/compiled-from-Haskell/sum-left-data/2500 13.72 ms 13.19 ms -3.9%
sum/compiled-from-Haskell/sum-left-data/5000 28.82 ms 27.66 ms -4.0%
sum/hand-written-PLC/sum-right-builtin/100 93.45 μs 91.51 μs -2.1%
sum/hand-written-PLC/sum-right-builtin/500 469.2 μs 458.4 μs -2.3%
sum/hand-written-PLC/sum-right-builtin/1000 964.3 μs 942.9 μs -2.2%
sum/hand-written-PLC/sum-right-builtin/2500 2.754 ms 2.699 ms -2.0%
sum/hand-written-PLC/sum-right-builtin/5000 5.911 ms 5.802 ms -1.8%
sum/hand-written-PLC/sum-right-Scott/100 74.28 μs 72.19 μs -2.8%
sum/hand-written-PLC/sum-right-Scott/500 377.7 μs 371.5 μs -1.6%
sum/hand-written-PLC/sum-right-Scott/1000 784.5 μs 778.0 μs -0.8%
sum/hand-written-PLC/sum-right-Scott/2500 2.375 ms 2.354 ms -0.9%
sum/hand-written-PLC/sum-right-Scott/5000 5.575 ms 5.553 ms -0.4%
sum/hand-written-PLC/sum-left-builtin/100 97.71 μs 94.25 μs -3.5%
sum/hand-written-PLC/sum-left-builtin/500 492.0 μs 470.4 μs -4.4%
sum/hand-written-PLC/sum-left-builtin/1000 979.0 μs 932.7 μs -4.7%
sum/hand-written-PLC/sum-left-builtin/2500 2.438 ms 2.330 ms -4.4%
sum/hand-written-PLC/sum-left-builtin/5000 4.855 ms 4.641 ms -4.4%
sum/hand-written-PLC/sum-left-Scott/100 82.15 μs 78.63 μs -4.3%
sum/hand-written-PLC/sum-left-Scott/500 404.6 μs 385.1 μs -4.8%
sum/hand-written-PLC/sum-left-Scott/1000 822.5 μs 793.9 μs -3.5%
sum/hand-written-PLC/sum-left-Scott/2500 2.298 ms 2.221 ms -3.4%
sum/hand-written-PLC/sum-left-Scott/5000 5.018 ms 4.844 ms -3.5%
1d9a758 6169ff7 Change
TOTAL 597.1 ms 577.6 ms -3.3%

Copy link
Contributor

Click here to check the status of your benchmark.

@effectfully
Copy link
Contributor Author

/benchmark nofib

@effectfully
Copy link
Contributor Author

/benchmark lists

Copy link
Contributor

Comparing benchmark results of 'lists' on '1d9a758c1f' (base) and '6169ff7b1b' (PR)

Results table
Script 1d9a758 6169ff7 Change
sort/ghcSort/50 334.0 μs 331.7 μs -0.7%
sort/ghcSort/100 780.8 μs 779.8 μs -0.1%
sort/ghcSort/150 1.348 ms 1.347 ms -0.1%
sort/ghcSort/200 1.819 ms 1.815 ms -0.2%
sort/ghcSort/250 2.349 ms 2.346 ms -0.1%
sort/ghcSort/300 3.103 ms 3.103 ms 0.0%
sort/insertionSort/50 1.133 ms 1.122 ms -1.0%
sort/insertionSort/100 4.520 ms 4.476 ms -1.0%
sort/insertionSort/150 10.18 ms 10.10 ms -0.8%
sort/insertionSort/200 18.21 ms 17.94 ms -1.5%
sort/insertionSort/250 28.59 ms 28.36 ms -0.8%
sort/insertionSort/300 41.34 ms 40.75 ms -1.4%
sort/mergeSort/50 985.6 μs 987.5 μs +0.2%
sort/mergeSort/100 2.266 ms 2.267 ms +0.0%
sort/mergeSort/150 3.652 ms 3.638 ms -0.4%
sort/mergeSort/200 5.134 ms 5.119 ms -0.3%
sort/mergeSort/250 6.698 ms 6.712 ms +0.2%
sort/mergeSort/300 8.179 ms 8.159 ms -0.2%
sort/quickSort/50 2.765 ms 2.746 ms -0.7%
sort/quickSort/100 11.13 ms 11.12 ms -0.1%
sort/quickSort/150 25.15 ms 25.04 ms -0.4%
sort/quickSort/200 44.46 ms 44.33 ms -0.3%
sort/quickSort/250 69.52 ms 69.38 ms -0.2%
sort/quickSort/300 100.6 ms 100.0 ms -0.6%
sum/compiled-from-Haskell/sum-right-builtin/100 131.3 μs 129.2 μs -1.6%
sum/compiled-from-Haskell/sum-right-builtin/500 677.3 μs 676.4 μs -0.1%
sum/compiled-from-Haskell/sum-right-builtin/1000 1.454 ms 1.449 ms -0.3%
sum/compiled-from-Haskell/sum-right-builtin/2500 4.317 ms 4.306 ms -0.3%
sum/compiled-from-Haskell/sum-right-builtin/5000 9.216 ms 9.226 ms +0.1%
sum/compiled-from-Haskell/sum-right-Scott/100 87.63 μs 88.70 μs +1.2%
sum/compiled-from-Haskell/sum-right-Scott/500 465.3 μs 470.2 μs +1.1%
sum/compiled-from-Haskell/sum-right-Scott/1000 1.039 ms 1.053 ms +1.3%
sum/compiled-from-Haskell/sum-right-Scott/2500 3.269 ms 3.299 ms +0.9%
sum/compiled-from-Haskell/sum-right-Scott/5000 7.253 ms 7.288 ms +0.5%
sum/compiled-from-Haskell/sum-right-data/100 402.0 μs 399.7 μs -0.6%
sum/compiled-from-Haskell/sum-right-data/500 2.236 ms 2.219 ms -0.8%
sum/compiled-from-Haskell/sum-right-data/1000 4.937 ms 4.918 ms -0.4%
sum/compiled-from-Haskell/sum-right-data/2500 13.14 ms 13.13 ms -0.1%
sum/compiled-from-Haskell/sum-right-data/5000 27.17 ms 27.23 ms +0.2%
sum/compiled-from-Haskell/sum-left-builtin/100 129.0 μs 128.2 μs -0.6%
sum/compiled-from-Haskell/sum-left-builtin/500 669.5 μs 665.6 μs -0.6%
sum/compiled-from-Haskell/sum-left-builtin/1000 1.428 ms 1.421 ms -0.5%
sum/compiled-from-Haskell/sum-left-builtin/2500 4.265 ms 4.250 ms -0.4%
sum/compiled-from-Haskell/sum-left-builtin/5000 9.230 ms 9.239 ms +0.1%
sum/compiled-from-Haskell/sum-left-Scott/100 86.61 μs 86.73 μs +0.1%
sum/compiled-from-Haskell/sum-left-Scott/500 458.2 μs 456.4 μs -0.4%
sum/compiled-from-Haskell/sum-left-Scott/1000 987.5 μs 984.4 μs -0.3%
sum/compiled-from-Haskell/sum-left-Scott/2500 3.178 ms 3.167 ms -0.3%
sum/compiled-from-Haskell/sum-left-Scott/5000 7.220 ms 7.170 ms -0.7%
sum/compiled-from-Haskell/sum-left-data/100 417.2 μs 405.0 μs -2.9%
sum/compiled-from-Haskell/sum-left-data/500 2.305 ms 2.248 ms -2.5%
sum/compiled-from-Haskell/sum-left-data/1000 5.118 ms 5.002 ms -2.3%
sum/compiled-from-Haskell/sum-left-data/2500 13.49 ms 13.25 ms -1.8%
sum/compiled-from-Haskell/sum-left-data/5000 28.40 ms 27.77 ms -2.2%
sum/hand-written-PLC/sum-right-builtin/100 93.49 μs 91.46 μs -2.2%
sum/hand-written-PLC/sum-right-builtin/500 471.4 μs 461.3 μs -2.1%
sum/hand-written-PLC/sum-right-builtin/1000 966.4 μs 945.3 μs -2.2%
sum/hand-written-PLC/sum-right-builtin/2500 2.756 ms 2.710 ms -1.7%
sum/hand-written-PLC/sum-right-builtin/5000 5.918 ms 5.822 ms -1.6%
sum/hand-written-PLC/sum-right-Scott/100 74.48 μs 72.29 μs -2.9%
sum/hand-written-PLC/sum-right-Scott/500 379.1 μs 372.5 μs -1.7%
sum/hand-written-PLC/sum-right-Scott/1000 787.7 μs 779.8 μs -1.0%
sum/hand-written-PLC/sum-right-Scott/2500 2.376 ms 2.376 ms 0.0%
sum/hand-written-PLC/sum-right-Scott/5000 5.570 ms 5.563 ms -0.1%
sum/hand-written-PLC/sum-left-builtin/100 98.40 μs 94.04 μs -4.4%
sum/hand-written-PLC/sum-left-builtin/500 493.9 μs 472.4 μs -4.4%
sum/hand-written-PLC/sum-left-builtin/1000 982.5 μs 938.2 μs -4.5%
sum/hand-written-PLC/sum-left-builtin/2500 2.449 ms 2.330 ms -4.9%
sum/hand-written-PLC/sum-left-builtin/5000 4.865 ms 4.654 ms -4.3%
sum/hand-written-PLC/sum-left-Scott/100 82.45 μs 79.52 μs -3.6%
sum/hand-written-PLC/sum-left-Scott/500 405.2 μs 391.3 μs -3.4%
sum/hand-written-PLC/sum-left-Scott/1000 820.6 μs 794.8 μs -3.1%
sum/hand-written-PLC/sum-left-Scott/2500 2.299 ms 2.225 ms -3.2%
sum/hand-written-PLC/sum-left-Scott/5000 5.010 ms 4.857 ms -3.1%
1d9a758 6169ff7 Change
TOTAL 584.3 ms 580.1 ms -0.7%

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'nofib' on '1d9a758c1f' (base) and '6169ff7b1b' (PR)

Results table
Script 1d9a758 6169ff7 Change
clausify/formula1 4.374 ms 4.416 ms +1.0%
clausify/formula2 5.835 ms 5.907 ms +1.2%
clausify/formula3 15.93 ms 16.17 ms +1.5%
clausify/formula4 36.49 ms 36.88 ms +1.1%
clausify/formula5 77.20 ms 78.43 ms +1.6%
knights/4x4 25.34 ms 25.32 ms -0.1%
knights/6x6 66.51 ms 67.33 ms +1.2%
knights/8x8 117.3 ms 118.3 ms +0.9%
primetest/05digits 15.06 ms 14.68 ms -2.5%
primetest/10digits 29.43 ms 28.54 ms -3.0%
primetest/30digits 91.31 ms 88.75 ms -2.8%
primetest/50digits 150.0 ms 146.8 ms -2.1%
queens4x4/bt 7.682 ms 7.654 ms -0.4%
queens4x4/bm 9.672 ms 9.707 ms +0.4%
queens4x4/bjbt1 9.314 ms 9.310 ms -0.0%
queens4x4/bjbt2 8.734 ms 8.698 ms -0.4%
queens4x4/fc 19.56 ms 19.77 ms +1.1%
queens5x5/bt 104.4 ms 104.5 ms +0.1%
queens5x5/bm 108.5 ms 109.4 ms +0.8%
queens5x5/bjbt1 122.0 ms 122.2 ms +0.2%
queens5x5/bjbt2 118.2 ms 118.6 ms +0.3%
queens5x5/fc 248.7 ms 250.3 ms +0.6%
1d9a758 6169ff7 Change
TOTAL 1.392 s 1.392 s +0.0%

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'nofib' on '1d9a758c1f' (base) and '6169ff7b1b' (PR)

Results table
Script 1d9a758 6169ff7 Change
clausify/formula1 4.345 ms 4.444 ms +2.3%
clausify/formula2 5.799 ms 5.941 ms +2.4%
clausify/formula3 15.86 ms 16.32 ms +2.9%
clausify/formula4 36.28 ms 37.12 ms +2.3%
clausify/formula5 76.67 ms 78.81 ms +2.8%
knights/4x4 25.18 ms 25.57 ms +1.5%
knights/6x6 65.94 ms 67.54 ms +2.4%
knights/8x8 116.2 ms 118.7 ms +2.2%
primetest/05digits 14.99 ms 14.78 ms -1.4%
primetest/10digits 29.07 ms 28.89 ms -0.6%
primetest/30digits 89.75 ms 89.89 ms +0.2%
primetest/50digits 147.8 ms 148.0 ms +0.1%
queens4x4/bt 7.624 ms 7.701 ms +1.0%
queens4x4/bm 9.624 ms 9.814 ms +2.0%
queens4x4/bjbt1 9.270 ms 9.369 ms +1.1%
queens4x4/bjbt2 8.668 ms 8.760 ms +1.1%
queens4x4/fc 19.48 ms 19.82 ms +1.7%
queens5x5/bt 104.0 ms 105.3 ms +1.2%
queens5x5/bm 107.8 ms 110.0 ms +2.0%
queens5x5/bjbt1 121.4 ms 122.8 ms +1.2%
queens5x5/bjbt2 117.9 ms 119.2 ms +1.1%
queens5x5/fc 247.7 ms 252.3 ms +1.9%
1d9a758 6169ff7 Change
TOTAL 1.381 s 1.401 s +1.4%

Copy link
Contributor

Click here to check the status of your benchmark.

Copy link
Contributor

Comparing benchmark results of 'lists' on '1d9a758c1f' (base) and '6169ff7b1b' (PR)

Results table
Script 1d9a758 6169ff7 Change
sort/ghcSort/50 334.5 μs 332.7 μs -0.5%
sort/ghcSort/100 781.3 μs 779.6 μs -0.2%
sort/ghcSort/150 1.352 ms 1.355 ms +0.2%
sort/ghcSort/200 1.822 ms 1.816 ms -0.3%
sort/ghcSort/250 2.354 ms 2.347 ms -0.3%
sort/ghcSort/300 3.105 ms 3.102 ms -0.1%
sort/insertionSort/50 1.134 ms 1.122 ms -1.1%
sort/insertionSort/100 4.522 ms 4.477 ms -1.0%
sort/insertionSort/150 10.20 ms 10.08 ms -1.2%
sort/insertionSort/200 18.20 ms 17.95 ms -1.4%
sort/insertionSort/250 28.56 ms 28.27 ms -1.0%
sort/insertionSort/300 41.33 ms 40.79 ms -1.3%
sort/mergeSort/50 987.2 μs 983.5 μs -0.4%
sort/mergeSort/100 2.265 ms 2.266 ms +0.0%
sort/mergeSort/150 3.652 ms 3.638 ms -0.4%
sort/mergeSort/200 5.133 ms 5.133 ms 0.0%
sort/mergeSort/250 6.711 ms 6.727 ms +0.2%
sort/mergeSort/300 8.193 ms 8.191 ms -0.0%
sort/quickSort/50 2.769 ms 2.754 ms -0.5%
sort/quickSort/100 11.18 ms 11.16 ms -0.2%
sort/quickSort/150 25.19 ms 25.01 ms -0.7%
sort/quickSort/200 44.58 ms 44.39 ms -0.4%
sort/quickSort/250 69.61 ms 69.34 ms -0.4%
sort/quickSort/300 101.0 ms 100.3 ms -0.7%
sum/compiled-from-Haskell/sum-right-builtin/100 131.7 μs 129.5 μs -1.7%
sum/compiled-from-Haskell/sum-right-builtin/500 678.8 μs 676.9 μs -0.3%
sum/compiled-from-Haskell/sum-right-builtin/1000 1.451 ms 1.441 ms -0.7%
sum/compiled-from-Haskell/sum-right-builtin/2500 4.316 ms 4.306 ms -0.2%
sum/compiled-from-Haskell/sum-right-builtin/5000 9.244 ms 9.226 ms -0.2%
sum/compiled-from-Haskell/sum-right-Scott/100 87.93 μs 88.53 μs +0.7%
sum/compiled-from-Haskell/sum-right-Scott/500 466.8 μs 471.0 μs +0.9%
sum/compiled-from-Haskell/sum-right-Scott/1000 1.044 ms 1.051 ms +0.7%
sum/compiled-from-Haskell/sum-right-Scott/2500 3.274 ms 3.296 ms +0.7%
sum/compiled-from-Haskell/sum-right-Scott/5000 7.281 ms 7.307 ms +0.4%
sum/compiled-from-Haskell/sum-right-data/100 404.4 μs 398.9 μs -1.4%
sum/compiled-from-Haskell/sum-right-data/500 2.239 ms 2.219 ms -0.9%
sum/compiled-from-Haskell/sum-right-data/1000 4.941 ms 4.912 ms -0.6%
sum/compiled-from-Haskell/sum-right-data/2500 13.16 ms 13.12 ms -0.3%
sum/compiled-from-Haskell/sum-right-data/5000 27.26 ms 27.20 ms -0.2%
sum/compiled-from-Haskell/sum-left-builtin/100 129.3 μs 128.4 μs -0.7%
sum/compiled-from-Haskell/sum-left-builtin/500 671.6 μs 667.1 μs -0.7%
sum/compiled-from-Haskell/sum-left-builtin/1000 1.432 ms 1.423 ms -0.6%
sum/compiled-from-Haskell/sum-left-builtin/2500 4.276 ms 4.253 ms -0.5%
sum/compiled-from-Haskell/sum-left-builtin/5000 9.243 ms 9.252 ms +0.1%
sum/compiled-from-Haskell/sum-left-Scott/100 86.78 μs 86.89 μs +0.1%
sum/compiled-from-Haskell/sum-left-Scott/500 458.9 μs 456.4 μs -0.5%
sum/compiled-from-Haskell/sum-left-Scott/1000 989.0 μs 986.5 μs -0.3%
sum/compiled-from-Haskell/sum-left-Scott/2500 3.184 ms 3.175 ms -0.3%
sum/compiled-from-Haskell/sum-left-Scott/5000 7.244 ms 7.182 ms -0.9%
sum/compiled-from-Haskell/sum-left-data/100 416.9 μs 405.8 μs -2.7%
sum/compiled-from-Haskell/sum-left-data/500 2.309 ms 2.248 ms -2.6%
sum/compiled-from-Haskell/sum-left-data/1000 5.118 ms 5.001 ms -2.3%
sum/compiled-from-Haskell/sum-left-data/2500 13.49 ms 13.25 ms -1.8%
sum/compiled-from-Haskell/sum-left-data/5000 28.52 ms 27.86 ms -2.3%
sum/hand-written-PLC/sum-right-builtin/100 93.76 μs 91.23 μs -2.7%
sum/hand-written-PLC/sum-right-builtin/500 469.2 μs 461.0 μs -1.7%
sum/hand-written-PLC/sum-right-builtin/1000 964.4 μs 949.3 μs -1.6%
sum/hand-written-PLC/sum-right-builtin/2500 2.759 ms 2.715 ms -1.6%
sum/hand-written-PLC/sum-right-builtin/5000 5.900 ms 5.838 ms -1.1%
sum/hand-written-PLC/sum-right-Scott/100 74.20 μs 72.89 μs -1.8%
sum/hand-written-PLC/sum-right-Scott/500 378.4 μs 368.5 μs -2.6%
sum/hand-written-PLC/sum-right-Scott/1000 787.8 μs 780.9 μs -0.9%
sum/hand-written-PLC/sum-right-Scott/2500 2.382 ms 2.365 ms -0.7%
sum/hand-written-PLC/sum-right-Scott/5000 5.593 ms 5.553 ms -0.7%
sum/hand-written-PLC/sum-left-builtin/100 98.22 μs 94.95 μs -3.3%
sum/hand-written-PLC/sum-left-builtin/500 492.7 μs 472.7 μs -4.1%
sum/hand-written-PLC/sum-left-builtin/1000 979.4 μs 942.3 μs -3.8%
sum/hand-written-PLC/sum-left-builtin/2500 2.446 ms 2.334 ms -4.6%
sum/hand-written-PLC/sum-left-builtin/5000 4.865 ms 4.662 ms -4.2%
sum/hand-written-PLC/sum-left-Scott/100 82.58 μs 78.55 μs -4.9%
sum/hand-written-PLC/sum-left-Scott/500 406.0 μs 385.8 μs -5.0%
sum/hand-written-PLC/sum-left-Scott/1000 822.9 μs 797.1 μs -3.1%
sum/hand-written-PLC/sum-left-Scott/2500 2.305 ms 2.225 ms -3.5%
sum/hand-written-PLC/sum-left-Scott/5000 5.024 ms 4.874 ms -3.0%
1d9a758 6169ff7 Change
TOTAL 585.4 ms 580.6 ms -0.8%

@effectfully
Copy link
Contributor Author

effectfully commented Nov 18, 2024

OK, this doesn't look random in otherwise pretty neutral benchmarking results:

sum/hand-written-PLC/sum-left-builtin/100 	97.71 μs 	94.25 μs 	-3.5%
sum/hand-written-PLC/sum-left-builtin/500 	492.0 μs 	470.4 μs 	-4.4%
sum/hand-written-PLC/sum-left-builtin/1000 	979.0 μs 	932.7 μs 	-4.7%
sum/hand-written-PLC/sum-left-builtin/2500 	2.438 ms 	2.330 ms 	-4.4%
sum/hand-written-PLC/sum-left-builtin/5000 	4.855 ms 	4.641 ms 	-4.4%
sum/hand-written-PLC/sum-left-Scott/100 	82.15 μs 	78.63 μs 	-4.3%
sum/hand-written-PLC/sum-left-Scott/500 	404.6 μs 	385.1 μs 	-4.8%
sum/hand-written-PLC/sum-left-Scott/1000 	822.5 μs 	793.9 μs 	-3.5%
sum/hand-written-PLC/sum-left-Scott/2500 	2.298 ms 	2.221 ms 	-3.4%
sum/hand-written-PLC/sum-left-Scott/5000 	5.018 ms 	4.844 ms 	-3.5%

sum/hand-written-PLC/sum-left-builtin/100 	98.40 μs 	94.04 μs 	-4.4%
sum/hand-written-PLC/sum-left-builtin/500 	493.9 μs 	472.4 μs 	-4.4%
sum/hand-written-PLC/sum-left-builtin/1000 	982.5 μs 	938.2 μs 	-4.5%
sum/hand-written-PLC/sum-left-builtin/2500 	2.449 ms 	2.330 ms 	-4.9%
sum/hand-written-PLC/sum-left-builtin/5000 	4.865 ms 	4.654 ms 	-4.3%
sum/hand-written-PLC/sum-left-Scott/100 	82.45 μs 	79.52 μs 	-3.6%
sum/hand-written-PLC/sum-left-Scott/500 	405.2 μs 	391.3 μs 	-3.4%
sum/hand-written-PLC/sum-left-Scott/1000 	820.6 μs 	794.8 μs 	-3.1%
sum/hand-written-PLC/sum-left-Scott/2500 	2.299 ms 	2.225 ms 	-3.2%
sum/hand-written-PLC/sum-left-Scott/5000 	5.010 ms 	4.857 ms 	-3.1%

sum/hand-written-PLC/sum-left-builtin/100 	98.22 μs 	94.95 μs 	-3.3%
sum/hand-written-PLC/sum-left-builtin/500 	492.7 μs 	472.7 μs 	-4.1%
sum/hand-written-PLC/sum-left-builtin/1000 	979.4 μs 	942.3 μs 	-3.8%
sum/hand-written-PLC/sum-left-builtin/2500 	2.446 ms 	2.334 ms 	-4.6%
sum/hand-written-PLC/sum-left-builtin/5000 	4.865 ms 	4.662 ms 	-4.2%
sum/hand-written-PLC/sum-left-Scott/100 	82.58 μs 	78.55 μs 	-4.9%
sum/hand-written-PLC/sum-left-Scott/500 	406.0 μs 	385.8 μs 	-5.0%
sum/hand-written-PLC/sum-left-Scott/1000 	822.9 μs 	797.1 μs 	-3.1%
sum/hand-written-PLC/sum-left-Scott/2500 	2.305 ms 	2.225 ms 	-3.5%
sum/hand-written-PLC/sum-left-Scott/5000 	5.024 ms 	4.874 ms 	-3.0%

so I suppose we can claim some victory here as well.

@effectfully effectfully added the No Changelog Required Add this to skip the Changelog Check label Nov 18, 2024
@effectfully effectfully requested a review from Unisay November 18, 2024 22:24
@effectfully effectfully merged commit 28820ec into master Nov 19, 2024
9 of 10 checks passed
@effectfully effectfully deleted the effectfully/builtins/make-all-builtins-strict branch November 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builtins Evaluation No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants