-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Builtins] Make all builtins strict #6523
[Builtins] Make all builtins strict #6523
Conversation
/benchmark validation |
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '6e469a346b' (base) and '2fb2d22dcb' (PR) Results table
|
The benchmarking machine is still sick. |
/benchmark validation |
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '9b4e76a9a' (base) and '0a644b5af' (PR) Results table
|
…to effectfully/builtins/make-all-builtins-strict
0a644b5
to
3b689ae
Compare
/benchmark validation |
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '2411c01a8' (base) and '3b689ae88' (PR) Results table
|
…to effectfully/builtins/make-all-builtins-strict
/benchmark validation |
Click here to check the status of your benchmark. |
Comparing benchmark results of 'validation' on '9b27bf75f1' (base) and '1cfcd3e5ec' (PR) Results table
|
…to effectfully/builtins/make-all-builtins-strict
/benchmark nofib |
/benchmark lists |
Click here to check the status of your benchmark. |
Comparing benchmark results of 'nofib' on '1d9a758c1f' (base) and '6169ff7b1b' (PR) Results table
|
Click here to check the status of your benchmark. |
/benchmark nofib |
/benchmark lists |
Comparing benchmark results of 'lists' on '1d9a758c1f' (base) and '6169ff7b1b' (PR) Results table
|
Click here to check the status of your benchmark. |
/benchmark nofib |
/benchmark lists |
Comparing benchmark results of 'lists' on '1d9a758c1f' (base) and '6169ff7b1b' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'nofib' on '1d9a758c1f' (base) and '6169ff7b1b' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'nofib' on '1d9a758c1f' (base) and '6169ff7b1b' (PR) Results table
|
Click here to check the status of your benchmark. |
Comparing benchmark results of 'lists' on '1d9a758c1f' (base) and '6169ff7b1b' (PR) Results table
|
OK, this doesn't look random in otherwise pretty neutral benchmarking results:
so I suppose we can claim some victory here as well. |
I was investigating a weird behavior of a test and this is where it led me to. This PR is gonna be blocked by broken benchmarking though, but we really should make builtins strict, because laziness only reduces the quality of tests.