Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Create an INFO governance action #7

Closed
1 of 17 tasks
CarlosLopezDeLara opened this issue May 26, 2023 · 4 comments
Closed
1 of 17 tasks

[FEATURE] - Create an INFO governance action #7

CarlosLopezDeLara opened this issue May 26, 2023 · 4 comments
Assignees

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented May 26, 2023

What

As an ada holder I want to create an INFO governance action so that I can submit it to the chain.

This build on top of the action command from #6

It should be something like:

cardano-cli conway governance action create-info
--proposal-url 
--proposal-hash
--proposal-file
--out-file

--metadata-url expects a url containing the document part of the Info action.
--metadata-hash expects the hash of the document hosted on --metadata-url
--out-file is the path to the action file which we can later use on build or build-rawto include the action to a transaction body.

Why

Its one of the 7 governance actions listed on CIP1694. CLI is the primary way to interact with the blockchain

Personas

  • SPOs
  • dApp Devs
  • Exchanges
  • Wallets
  • 3rd party tools
  • ADA holders

Definition of Done (DoD)

  • Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
  • Builds successfully on CI
  • Code & Test review (as per Acceptance Criteria)
  • There is documentation and/or examples for the new functionality (usage/response)
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number(s) included in PR description
  • All Acceptance Criteria met and covered by dev/unit/property/integration tests
  • System/E2E automated tests + System Test Engineer Owner Sign-off

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

  • Product Owner
  • Dev Owner
  • System Test Engineer Owner

Related PRs

  1. cardano-cli: add governance create-info command #292

Acceptance Criteria

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@smelc
Copy link
Contributor

smelc commented Sep 19, 2023

Hey @CarlosLopezDeLara, I'm not sure how to understand the description:

cardano-cli conway governance action create-info
--proposal-url 
--proposal-hash
--proposal-file
--out-file

--metadata-url expects a url containing the document part of the Info action.
--metadata-hash expects the hash of the document hosted on --metadata-url
--out-file is the path to the action file which we can later use on build or build-rawto include the action to a transaction body.

The --help snippet lists 4 parameters to create-info, but then you describe three of them in the text that follows and they have slightly different names (e.g. proposal versus metadata).

Could you detail a bit more?

[edit] Was clarified on Slack: discussion

@CarlosLopezDeLara
Copy link
Contributor Author

resolved in #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants