Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Implement treasury donations on the CLI #590

Closed
CarlosLopezDeLara opened this issue Jan 24, 2024 · 5 comments · Fixed by #778
Closed

[FR] - Implement treasury donations on the CLI #590

CarlosLopezDeLara opened this issue Jan 24, 2024 · 5 comments · Fixed by #778
Assignees

Comments

@CarlosLopezDeLara
Copy link
Contributor

CarlosLopezDeLara commented Jan 24, 2024

Internal/External
Internal if an IOHK staff member.

Area
Transactions, treasury donations.

Describe the feature you'd like
Update conway transaction build and build raw commands to support the new "donate to the treasury" feature.

A new flag --treasury-donation should be enough. This requires a change on the API

conway cddl:

transaction_body =
  { 0 : set<transaction_input>             ; inputs
  , 1 : [* transaction_output]
  , 2 : coin                               ; fee
  , ? 3 : uint                             ; time to live
  , ? 4 : certificates
  , ? 5 : withdrawals
  , ? 7 : auxiliary_data_hash
  , ? 8 : uint                             ; validity interval start
  , ? 9 : mint
  , ? 11 : script_data_hash
  , ? 13 : nonempty_set<transaction_input> ; collateral inputs
  , ? 14 : required_signers
  , ? 15 : network_id
  , ? 16 : transaction_output              ; collateral return
  , ? 17 : coin                            ; total collateral
  , ? 18 : nonempty_set<transaction_input> ; reference inputs
  , ? 19 : voting_procedures               ; New; Voting procedures
  , ? 20 : proposal_procedures             ; New; Proposal procedures
  , ? 21 : coin                            ; New; current treasury value
  , ? 22 : positive_coin                   ; New; donation
  }

See Conway TxBody in Ledger
https://github.com/IntersectMBO/cardano-ledger/blob/5f76eb918c16645ed98a7fbab513c2d549837ed5/eras/conway/impl/src/Cardano/Ledger/Conway/TxBody.hs#L656-L681

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Feb 24, 2024
@smelc smelc removed the Stale label Mar 4, 2024
@smelc
Copy link
Contributor

smelc commented Mar 4, 2024

Taking it, as discussed with @CarlosLopezDeLara today.

@smelc smelc self-assigned this Mar 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Apr 4, 2024
@smelc smelc removed the Stale label Apr 4, 2024
Copy link

github-actions bot commented May 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

Copy link

github-actions bot commented Jun 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Jun 6, 2024
@smelc smelc removed the Stale label Jun 6, 2024
@smelc smelc closed this as completed in #778 Jul 1, 2024
@CarlosLopezDeLara CarlosLopezDeLara added this to the SanchoNet Phase 6 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants