Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding emojis broke wasm build #2

Open
extrawurst opened this issue Sep 8, 2023 · 3 comments
Open

adding emojis broke wasm build #2

extrawurst opened this issue Sep 8, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@extrawurst
Copy link

with f3adda1 and adding twemoji-rs unconditionally as a dependency wordcloud-rs does not longer run in wasm environments anymore. unfortunately it will only break at runtime with:

panicked at 'called `Result::unwrap()` on an `Err` value: Error { kind: Unsupported, message: "operation not supported on this platform" }', /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/twemoji-rs-0.1.2/src/lib.rs:10:37

could you make emoji support conditional so it could be disabled via features?

@Inspirateur
Copy link
Owner

I'm quite busy with work and other projects so idk when i'll fix this but thanks for pointing it out !

@Inspirateur
Copy link
Owner

I know it's been a while but just so you know I'm currently reworking the accelerating structure for collision checks, and after that I plan to tackle this issue :)

@Inspirateur
Copy link
Owner

Ok, I finished reworking the acceleration structure, which is now in its own crate https://crates.io/crates/binary_raster and I added the default feature "fs" which you can disable to skip all filesystem usage (meaning it won't load emoji images and such).

It should work ? but please tell me if something is wrong :)

@Inspirateur Inspirateur added the bug Something isn't working label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants