Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out type of constants argument in microclimate.py #358

Open
vgro opened this issue Jan 9, 2024 · 1 comment
Open

Sort out type of constants argument in microclimate.py #358

vgro opened this issue Jan 9, 2024 · 1 comment

Comments

@vgro
Copy link
Collaborator

vgro commented Jan 9, 2024

At the moment, the type for constants in the microclimate submodule is set to AbioticSimpleConsts which is not general enough and makes it very clunky to use the function in a different model (it is used in the setup of the mechanistic abiotic model).

As soon as we solved the issues #162, #208, #342 and others on where to move which constants and how to call them, this needs to be changed accordingly.

@davidorme
Copy link
Collaborator

Over in #364, we've suggested using meta constants classes as a way of sharing constants among multiple models and which can be used to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants