Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soil moisture isn't actually needed in the Virtual Rainforest simulation #345

Closed
jacobcook1995 opened this issue Nov 30, 2023 · 1 comment · Fixed by #420
Closed

Soil moisture isn't actually needed in the Virtual Rainforest simulation #345

jacobcook1995 opened this issue Nov 30, 2023 · 1 comment · Fixed by #420
Assignees

Comments

@jacobcook1995
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
At the moment the hydrology model calculates soil moisture, but none of the other models actually need to use it. At the moment, the soil model uses it to calculate amount of water in the topsoil layer, something the hydrology model could return instead.

Describe the solution you'd like
The hydrology model could get rid of the soil moisture calculation, and just return the quantity the soil model needs instead. It might be worth retaining the soil moisture calculation function, as this is a nice output to have though.

@vgro
Copy link
Collaborator

vgro commented Dec 5, 2023

For clarification, we keep the soil moisture variable but instead of a relative water content, we calculate absolute water content in mm at a given depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants