Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Validates if 'lis_outcome_service_url' and 'lis_result_sourcedid' fields exist #95

Merged
merged 4 commits into from
Jun 3, 2020

Conversation

netoisc
Copy link
Contributor

@netoisc netoisc commented Jun 2, 2020

When the student comes from the main course menu these fields are not present. With this fix both missing fields will be ignored (in the login process) but the grade submission will not work for this student.
Fixes #94

…elds exist before register them in control file
@netoisc netoisc added the fix Fixes a bug label Jun 2, 2020
@netoisc netoisc requested a review from jgwerner June 2, 2020 15:27
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #95 into master will increase coverage by 0.55%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   66.48%   67.03%   +0.55%     
==========================================
  Files          13       13              
  Lines         904      907       +3     
==========================================
+ Hits          601      608       +7     
+ Misses        303      299       -4     
Impacted Files Coverage Δ
src/illumidesk/authenticators/authenticator.py 65.38% <66.66%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6923f8f...5336550. Read the comment docs.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 105e854 into IllumiDesk:master Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid outcome service url when launching tool from course menu
2 participants