Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Update JupyterHub configuration to use raw_username with DockerSpawner #85

Merged
merged 6 commits into from
May 26, 2020

Conversation

jgwerner
Copy link
Member

Updates DockerSpawner to use raw_username instead of username for docker volumes and container names.

This update adds support for the _ character in usernames.

@jgwerner jgwerner added the fix Fixes a bug label May 25, 2020
@jgwerner jgwerner requested a review from netoisc May 25, 2020 18:34
@jgwerner jgwerner self-assigned this May 25, 2020
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   78.97%   78.97%           
=======================================
  Files          24       24           
  Lines        1788     1788           
=======================================
  Hits         1412     1412           
  Misses        376      376           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0160d3e...da875ed. Read the comment docs.

@jgwerner jgwerner merged commit c518bd5 into IllumiDesk:master May 26, 2020
@jgwerner jgwerner deleted the fix/raw-username branch May 26, 2020 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant