Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Feature to add a postgres service for labs #75

Merged
merged 5 commits into from
May 23, 2020

Conversation

netoisc
Copy link
Contributor

@netoisc netoisc commented May 23, 2020

  • add postgres dependency for notebooks
  • add new service definition in docker-compose
  • add new ansible flag to indicate when to use this service

How to use with python:

import psycopg2
conn = psycopg2.connect(host="postgres-labs", database="labs", user="postgres", password="postgres")

…m notebooks as local database. Install psycopg2-binary package in notebooks base image
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          11       11           
  Lines         710      710           
=======================================
  Hits          413      413           
  Misses        297      297           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a3092e...8270eff. Read the comment docs.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also add a section to the Readme so the user is aware of this configuration option. We would add instructions to the user guide docs separately, so the README.md should have config options to enable or disable the service along with some basic instructions on how to access the DB from the notebook(s).

@jgwerner jgwerner added the feature New feature or request label May 23, 2020
Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit b733c0b into IllumiDesk:master May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants