This repository was archived by the owner on Sep 5, 2023. It is now read-only.
Handle missing lis arguments with learner launch requests #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…learner launch requests Signed-off-by: Greg <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 58.33% 58.16% -0.17%
==========================================
Files 11 11
Lines 708 710 +2
==========================================
Hits 413 413
- Misses 295 297 +2
Continue to review full report at Codecov.
|
…o fix/lis_outcome_service_url
Signed-off-by: Greg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle missing lis_outcome_service_url and lis_result_sourcedid arguments with Learner launch requests as well as empty values for when they are included with the launch request.
To replicate:
Initiate a launch request from the Canvas LMS with default values which do not include
lis_*arguments.