Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Do not use initial course service when LTI is enabled #53

Merged
merged 4 commits into from
May 12, 2020
Merged

Do not use initial course service when LTI is enabled #53

merged 4 commits into from
May 12, 2020

Conversation

netoisc
Copy link
Contributor

@netoisc netoisc commented May 12, 2020 •
edited
Loading

  • remove course definition from docker-compose and jupyterhub_config_lti11.py
  • remove user groups
  • do not copy the env.service file
  • remove some vars in env.jhub related to initial course

@codecov
Copy link

codecov bot commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #53   +/-   ##
=======================================
  Coverage   57.71%   57.71%           
=======================================
  Files          10       10           
  Lines         726      726           
=======================================
  Hits          419      419           
  Misses        307      307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfdd22...f8a0c9f. Read the comment docs.

@jgwerner jgwerner self-requested a review May 12, 2020 15:12
@jgwerner jgwerner added the feature New feature or request label May 12, 2020
jgwerner
jgwerner previously approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgwerner
jgwerner reviewed May 12, 2020
View reviewed changes
@jgwerner jgwerner self-requested a review May 12, 2020 17:06
@jgwerner jgwerner dismissed their stale review May 12, 2020 17:09

Rolling back approval

jgwerner
jgwerner suggested changes May 12, 2020
View reviewed changes
Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert readme removals and adjust formatting.

jgwerner
jgwerner approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM v2

@jgwerner jgwerner merged commit 2ab217e into IllumiDesk:master May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgwerner jgwerner jgwerner approved these changes

Assignees

@netoisc netoisc

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netoisc @jgwerner