Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Remove announcement service #515

Merged
merged 8 commits into from
Feb 16, 2021

Conversation

jgwerner
Copy link
Member

  • Removes announcement services and tests
  • Removes announcement service call from LTI 1.1 authenticator

@jgwerner jgwerner added the refactor Move code around to keep things DRY label Feb 16, 2021
@jgwerner jgwerner requested a review from Abhi94N February 16, 2021 17:58
@jgwerner jgwerner self-assigned this Feb 16, 2021
@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #515 (721443f) into main (5552cf0) will decrease coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   75.94%   75.53%   -0.41%     
==========================================
  Files          17       16       -1     
  Lines        1139     1116      -23     
==========================================
- Hits          865      843      -22     
+ Misses        274      273       -1     
Impacted Files Coverage Δ
...umidesk/illumidesk/authenticators/authenticator.py 90.90% <ø> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5552cf0...721443f. Read the comment docs.

Copy link

@Abhi94N Abhi94N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 69fdbe2 into IllumiDesk:main Feb 16, 2021
@jgwerner jgwerner deleted the chore/remove-announcement-service branch February 16, 2021 18:13
@jgwerner jgwerner mentioned this pull request Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Move code around to keep things DRY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants