Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Improve the grader notebooks dropdown #358

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

netoisc
Copy link
Contributor

@netoisc netoisc commented Oct 8, 2020

Update the dropdown style to use a fixed length, to show scroll with long list

@netoisc netoisc requested a review from jgwerner October 8, 2020 16:52
@netoisc netoisc self-assigned this Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #358 into main will decrease coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   79.60%   79.16%   -0.45%     
==========================================
  Files          21       21              
  Lines        1368     1382      +14     
==========================================
+ Hits         1089     1094       +5     
- Misses        279      288       +9     
Impacted Files Coverage Δ
src/illumidesk/apis/nbgrader_service.py 71.42% <0.00%> (-5.50%) ⬇️
src/illumidesk/grades/senders.py 72.61% <0.00%> (-1.01%) ⬇️
src/illumidesk/lti13/handlers.py 57.14% <0.00%> (ø)
src/illumidesk/spawners/hooks.py 67.74% <0.00%> (ø)
src/illumidesk/apis/jupyterhub_api.py 60.18% <0.00%> (ø)
src/illumidesk/authenticators/constants.py 100.00% <0.00%> (ø)
src/illumidesk/authenticators/validator.py 85.36% <0.00%> (ø)
src/illumidesk/apis/setup_course_service.py 89.28% <0.00%> (ø)
src/illumidesk/authenticators/authenticator.py 92.46% <0.00%> (ø)
src/illumidesk/setup_course/course.py 81.81% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d5514...985317b. Read the comment docs.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner marked this pull request as ready for review October 9, 2020 00:21
@jgwerner jgwerner merged commit 898c159 into IllumiDesk:main Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants