This repository was archived by the owner on Sep 5, 2023. It is now read-only.
Add shutdown_on_logout config option #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Greg <[email protected]>
netoisc
suggested changes
Sep 9, 2020
ansible/roles/jupyterhub/templates/jupyterhub_config_base.py.j2
Outdated
Show resolved
Hide resolved
netoisc
suggested changes
Sep 9, 2020
ansible/roles/jupyterhub/templates/jupyterhub_config_base.py.j2
Outdated
Show resolved
Hide resolved
Signed-off-by: Greg <[email protected]>
|
Right, makes sense. I added a minor update to convert the string to bool and then return a bool (True/False). |
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
=======================================
Coverage 78.82% 78.82%
=======================================
Files 21 21
Lines 1360 1360
=======================================
Hits 1072 1072
Misses 288 288 Continue to review full report at Codecov.
|
netoisc
suggested changes
Sep 10, 2020
ansible/roles/jupyterhub/templates/jupyterhub_config_base.py.j2
Outdated
Show resolved
Hide resolved
Signed-off-by: Greg <[email protected]>
jgwerner
force-pushed
the
feat/stop-server-config
branch
from
fa5b030 to
14a8b06
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hosts.example