Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Update dockerspawner configuration settings #288

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

jgwerner
Copy link
Member

  • Sets user to root (0)
  • Sets NB_UID, NB_GID, NB_USER with spawner's environment option for good measure

This prepares the spawner to use the new base image. IllumiDesk/docker-stacks#21

@jgwerner jgwerner requested a review from netoisc August 20, 2020 23:54
@jgwerner jgwerner self-assigned this Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #288 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   80.24%   80.24%           
=======================================
  Files          21       21           
  Lines        1301     1301           
=======================================
  Hits         1044     1044           
  Misses        257      257           
Impacted Files Coverage Δ
src/illumidesk/setup_course/course.py 81.65% <ø> (ø)
src/illumidesk/spawners/spawners.py 86.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e89237...b414d90. Read the comment docs.

@jgwerner jgwerner added the feature New feature or request label Aug 20, 2020
Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit a8f4dac into IllumiDesk:main Aug 21, 2020
@jgwerner jgwerner deleted the feat/update-dockerspawner-configs branch August 21, 2020 00:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants