Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

fix: Update required claims and username value when private #241

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

jgwerner
Copy link
Member

Closes #240

@jgwerner jgwerner added the fix Fixes a bug label Jul 23, 2020
@jgwerner jgwerner requested a review from netoisc July 23, 2020 23:09
@jgwerner jgwerner self-assigned this Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #241 into main will increase coverage by 3.43%.
The diff coverage is 82.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   77.54%   80.97%   +3.43%     
==========================================
  Files          17       20       +3     
  Lines        1140     1188      +48     
==========================================
+ Hits          884      962      +78     
+ Misses        256      226      -30     
Impacted Files Coverage Δ
src/illumidesk/authenticators/constants.py 100.00% <ø> (ø)
src/illumidesk/grades/handlers.py 78.57% <ø> (ø)
src/illumidesk/authenticators/validator.py 83.80% <45.00%> (-6.29%) ⬇️
src/illumidesk/spawners/hooks.py 54.54% <54.54%> (ø)
src/illumidesk/spawners/spawners.py 86.04% <76.19%> (+37.99%) ⬆️
src/illumidesk/apis/setup_course_service.py 89.28% <89.28%> (ø)
src/illumidesk/setup_course/course.py 82.82% <94.11%> (+0.80%) ⬆️
src/illumidesk/apis/announcement_service.py 94.73% <94.73%> (ø)
src/illumidesk/authenticators/authenticator.py 96.11% <94.82%> (+3.71%) ⬆️
src/illumidesk/authenticators/utils.py 97.36% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20c6ca...35c9264. Read the comment docs.

Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jgwerner added 2 commits July 23, 2020 19:34
Signed-off-by: Greg <[email protected]>
Signed-off-by: Greg <[email protected]>
@jgwerner jgwerner merged commit 1c49ed6 into IllumiDesk:main Jul 23, 2020
@jgwerner jgwerner deleted the fix/lti13-with-privacy-enabled branch July 23, 2020 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

400 error when authenticating with LTI 1.3 with Privacy mode enabled
2 participants