Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Update ansible playbook and constants to remove nbgrader configuration #236

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

jgwerner
Copy link
Member

  • Remove nbgrader role form ansible playbook
  • Add constant for course config
  • Update tests

#235

@jgwerner jgwerner added feature New feature or request refactor Move code around to keep things DRY labels Jul 22, 2020
@jgwerner jgwerner requested a review from netoisc July 22, 2020 17:26
@jgwerner jgwerner self-assigned this Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #236 into main will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   80.75%   80.92%   +0.16%     
==========================================
  Files          19       19              
  Lines        1159     1169      +10     
==========================================
+ Hits          936      946      +10     
  Misses        223      223              
Impacted Files Coverage Δ
src/illumidesk/setup_course/constants.py 100.00% <100.00%> (ø)
src/illumidesk/setup_course/course.py 82.82% <100.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c50458...601a5e2. Read the comment docs.

Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this shouldn't have been in another new branch to definitely deprecate all things related to the Firstuse/grader service. But the changes seem all ok

@jgwerner jgwerner merged commit 2f229e3 into IllumiDesk:main Jul 22, 2020
@jgwerner jgwerner deleted the feat/rm-nbgrader-role branch July 22, 2020 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request refactor Move code around to keep things DRY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants