Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Update notebook base image #209

Merged
merged 3 commits into from
Jul 15, 2020

Conversation

jgwerner
Copy link
Member

Closes #208

@jgwerner jgwerner added the fix Fixes a bug label Jul 15, 2020
@jgwerner jgwerner requested a review from netoisc July 15, 2020 01:19
@jgwerner jgwerner self-assigned this Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #209 into main will increase coverage by 1.34%.
The diff coverage is 63.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   77.54%   78.88%   +1.34%     
==========================================
  Files          17       18       +1     
  Lines        1140     1132       -8     
==========================================
+ Hits          884      893       +9     
+ Misses        256      239      -17     
Impacted Files Coverage Δ
src/illumidesk/grades/handlers.py 78.57% <ø> (ø)
src/illumidesk/authenticators/validator.py 83.80% <45.00%> (-6.29%) ⬇️
src/illumidesk/spawners/hooks.py 54.54% <54.54%> (ø)
src/illumidesk/spawners/spawners.py 86.04% <76.19%> (+37.99%) ⬆️
src/illumidesk/authenticators/authenticator.py 92.39% <100.00%> (ø)
src/illumidesk/authenticators/utils.py 97.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb2d56...7be06a7. Read the comment docs.

Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit e16cccf into IllumiDesk:main Jul 15, 2020
@jgwerner jgwerner deleted the fix/jupyter-config-path branch July 15, 2020 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect jupyter_notebook_config.py location
2 participants