Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Normalize course label for lti 13 #198

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

jgwerner
Copy link
Member

Fixes an issue where the course name was not being normalized with LTI 1.3.

@jgwerner jgwerner added the fix Fixes a bug label Jul 10, 2020
@jgwerner jgwerner requested a review from netoisc July 10, 2020 22:26
@jgwerner jgwerner self-assigned this Jul 10, 2020
Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #198 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          18       18           
  Lines        1128     1128           
=======================================
  Hits          896      896           
  Misses        232      232           
Impacted Files Coverage Δ
src/illumidesk/authenticators/authenticator.py 92.39% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02c5b4d...001d419. Read the comment docs.

@jgwerner jgwerner merged commit 4d5cffe into IllumiDesk:main Jul 10, 2020
@jgwerner jgwerner deleted the fix/normalize-course-lti13 branch July 10, 2020 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants