Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Update authentication validation steps #168

Merged
merged 6 commits into from
Jul 1, 2020

Conversation

jgwerner
Copy link
Member

Segregate launch validation by steps as described in IMS Global's LTI 1.3 specification.

@jgwerner jgwerner added the fix Fixes a bug label Jun 29, 2020
@jgwerner jgwerner requested a review from netoisc June 29, 2020 15:28
@jgwerner jgwerner self-assigned this Jun 29, 2020
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #168 into main will increase coverage by 0.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   74.10%   75.05%   +0.95%     
==========================================
  Files          13       13              
  Lines         946      942       -4     
==========================================
+ Hits          701      707       +6     
+ Misses        245      235      -10     
Impacted Files Coverage Δ
src/illumidesk/authenticators/constants.py 100.00% <100.00%> (ø)
src/illumidesk/authenticators/handlers.py 90.00% <100.00%> (-1.18%) ⬇️
src/illumidesk/authenticators/validator.py 90.09% <100.00%> (+9.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8b9c9...3695674. Read the comment docs.

@jgwerner jgwerner requested a review from netoisc July 1, 2020 01:43
Signed-off-by: Greg <[email protected]>
Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit c507ca7 into IllumiDesk:main Jul 1, 2020
@jgwerner jgwerner deleted the fix/update-lti13-login-validator branch July 1, 2020 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants