Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Support additional workspace types #164

Merged
merged 43 commits into from
Jul 8, 2020

Conversation

jgwerner
Copy link
Member

@jgwerner jgwerner commented Jun 25, 2020

Adds support for custom workspace types:

  • RStudio
  • THEIA
  • VSCode

Closes #114
Closes #174
Closes #175
Closes #146

@jgwerner jgwerner added the feature New feature or request label Jun 25, 2020
@jgwerner jgwerner requested a review from netoisc June 25, 2020 18:47
@jgwerner jgwerner self-assigned this Jun 25, 2020
@jgwerner jgwerner changed the title Support additional workspace types [WIP] Support additional workspace types Jun 26, 2020
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #164 into main will decrease coverage by 1.12%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   78.67%   77.54%   -1.13%     
==========================================
  Files          17       17              
  Lines        1083     1140      +57     
==========================================
+ Hits          852      884      +32     
- Misses        231      256      +25     
Impacted Files Coverage Δ
src/illumidesk/spawners/spawners.py 48.05% <48.05%> (ø)
src/illumidesk/apis/jupyterhub_api.py 55.30% <100.00%> (ø)
src/illumidesk/authenticators/authenticator.py 92.39% <100.00%> (+0.62%) ⬆️
src/illumidesk/authenticators/constants.py 100.00% <100.00%> (ø)
src/illumidesk/grades/senders.py 71.01% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410691d...7bab691. Read the comment docs.

@jgwerner
Copy link
Member Author

Snyk has picked up on a vulnerability associated with scikit-learn (aka sklearn). The Common Vulnerabilities and Exposure identifier for this vulnerability states that the status is DISPUTED since the "joblib.load() function is documented as unsafe and it is the user's responsibility to use the function in a secure manner. Additionally, this vulnerability is associated with user notebook environments not the orchestrator."

A merge is therefore allowed.

@jgwerner jgwerner marked this pull request as draft June 27, 2020 04:43
@jgwerner jgwerner marked this pull request as ready for review June 29, 2020 00:30
@jgwerner jgwerner changed the title [WIP] Support additional workspace types Support additional workspace types Jun 29, 2020
@jgwerner
Copy link
Member Author

jgwerner commented Jul 1, 2020

Snyk lost track of the requirements.txt manifest that was previously in the notebooks folder which is now in the workspaces folder. Forced to passing and the will verify update upon merge.

@jgwerner jgwerner requested a review from netoisc July 1, 2020 23:00
Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 6c13bc9 into IllumiDesk:main Jul 8, 2020
@jgwerner jgwerner deleted the feat/workspace-types branch July 8, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
2 participants