Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel Component: Discrepancies between WC #15025

Closed
RivaIvanova opened this issue Nov 11, 2024 · 0 comments · Fixed by #15040
Closed

Carousel Component: Discrepancies between WC #15025

RivaIvanova opened this issue Nov 11, 2024 · 0 comments · Fixed by #15040
Assignees
@RivaIvanova
Labels
🎠 carousel 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@RivaIvanova
Copy link
Member

Is your feature request related to a problem? Please describe.

The default value of maximumIndicatorsCount for the WC carousel is 10 (which will also be for React and Blazor), whereas the default value of the Angular one is 5 (ref). When discussing the design of the WC carousel, it was decided that it is better to allow a greater value for the indicators count, hence 10.

The Angular carousel now allows vertical alignment, so the default values for the indicatorsOrientation - bottom and top (CarouselIndicatorsOrientation) are not appropriate. They should be changed to start and end to be aligned with the WC carousel indicatorsOrientation and to accommodate the new vertical mode.

Describe the solution you'd like

maximumIndicatorsCount should be set to 10.
CarouselIndicatorsOrientation should be set to start and end.
@RivaIvanova RivaIvanova self-assigned this Nov 11, 2024
@RivaIvanova RivaIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Nov 11, 2024
@RivaIvanova RivaIvanova mentioned this issue Nov 11, 2024
Merged
14 tasks
@RivaIvanova RivaIvanova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RivaIvanova RivaIvanova

Labels
🎠 carousel 🧰 feature-request ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(carousel): align with WC carousel IgniteUI/igniteui-angular
1 participant
@RivaIvanova