Feature: Add support to ignore empty checks on UsedPartitionSpace plugin and ignore Unknowns #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordHepipud
force-pushed
the
feature/allow_empty_checks_on_usedpartitionspace_plugin
branch
from
a0c0637 to
b81fc8f
Compare
LordHepipud
changed the title
LordHepipud
force-pushed
the
feature/allow_empty_checks_on_usedpartitionspace_plugin
branch
2 times, most recently
from
6c2ff87 to
d321463
Compare
* Plugin now supports to turn empty check packages from Unknown to Ok * Plugin now supports to set Unknown of partitions without metrics to Ok
LordHepipud
force-pushed
the
feature/allow_empty_checks_on_usedpartitionspace_plugin
branch
from
d321463 to
adf0a97
Compare
LordHepipud
deleted the
feature/allow_empty_checks_on_usedpartitionspace_plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should add support to ignore empty check packages in case we filtered all partitions out on the check. This might be required in certain scenarios and can be very helpful.
In addition it might be helpful to convert Unknown partition data to Ok for not causing false positives.