Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIMROD: fix camera homing #6934

Closed
3 tasks done
rerpha opened this issue Dec 7, 2021 · 4 comments
Closed
3 tasks done

NIMROD: fix camera homing #6934

rerpha opened this issue Dec 7, 2021 · 4 comments
Assignees
Labels
3 no_release_notes Tickets that do not need release notes, use sparingly! support

Comments

@rerpha
Copy link
Contributor

rerpha commented Dec 7, 2021

When setting up the motion setpoints + getting in/out positions for #6932 we decided to start off by homing (which was working last time we looked at it) but for some reason the Galil stopped on the upper limit and then didn't move anymore. This was solved by tweaking/jogging/sending a move but homing now does not finish. This may be related to #6631 as it uses the same homing routine currently.

Acceptance Criteria

What is the acceptance criteria?

  • Some time is booked with JN to investigate homing
  • Cause for this behaviour is found and written somewhere useful on the wiki
  • NIMROD camera is able to be homed again

Extra Information

We could try just using the forward limit homing routine rather than the routine that is currently used (forward limit + find index negative) but it's unusual that it just stopped working.

@rerpha rerpha changed the title NIMROD: Camera homing stopped working NIMROD: fix camera homing Dec 7, 2021
@rerpha rerpha added the proposal label Dec 7, 2021
@KathrynBaker
Copy link
Member

Consider homing to reverse limit (home out of the beam not into the beam)

@KathrynBaker KathrynBaker added the 3 label Jan 27, 2022
@KathrynBaker KathrynBaker added this to the SPRINT_2022_02_03 milestone Feb 3, 2022
@github-actions github-actions bot added ready and removed proposal labels Feb 3, 2022
@JackEAllen JackEAllen self-assigned this Feb 3, 2022
@github-actions github-actions bot added in progress and removed ready labels Feb 8, 2022
@rerpha
Copy link
Contributor Author

rerpha commented Feb 22, 2022

  • Nimrod homing routine changed from forwardlimFIneg to Reverselim (out of beam!)
  • offset applied so motionsetpoints still work - Outbeam is also home location
  • runcontrol applied on Outofbeam (inpos-for-Outbeam block) by scientists request

Whilst there we helped with some scripts and found a pylint exception (jack will create a new ticket for this, though looks to be a bug in pylint itself)

Scientists are happy with this after a demo so again not much to review here!

@rerpha rerpha added support no_release_notes Tickets that do not need release notes, use sparingly! labels Feb 22, 2022
@rerpha rerpha self-assigned this Feb 22, 2022
@LowriJenkins
Copy link
Contributor

If the scientists are happy with this, I'll be happy to put this to review complete once Jack has made a ticket for the exception.

@LowriJenkins
Copy link
Contributor

Ticket for pylint error is above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 no_release_notes Tickets that do not need release notes, use sparingly! support
Projects
None yet
Development

No branches or pull requests

4 participants