-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include configuration for git mode in libms #952
Comments
@prasadtalasila I think I need some more context for this issue. What are the goals/requirements? |
@nichlaes Yes. To serve files over git without showing the |
Hi Prasad. Can you add the link you used to show me an example of the the users on gitlab? |
please see gitlab.com |
Can you maybe elaborate on how you think it should be implemented. Should it clone all the files to the What is the overall goal of the feature? Just so I know what the implementation should solve. |
The scope of this issue is to just include Including git mode will require adding scaffolding in the existing code base to support this git mode. The goal is to just have scaffolding now and add the actual git functionality later. We used to have gitlab mode in libms wherein the gitlab is queried to fetch the files. This gitlab mode became non-functional due to upgrade of gitlab GraphQL API. The PR #435 has removed the gitlab mode. The changes made in that PR can show the scaffolding needed. Please use as an inspiration only; the design can perhaps be improved. |
The libms-gitlab-code commit contains the example code scaffolding for gitlab mode. We need similar one for git mode. |
I should have pushed the necessary code now. Should I also update the docs/markdown files? |
Thanks for the update. The code structure looks similar to the one we had for gitlab mode. Please think about the design suggestion made on this discussion page. I am hoping that it would result in modular code. We can have the design discussion on the discussion page and only check the code implementation on this page. In addition, please fix the failing tests and add tests for the git mode code as well. Thanks. |
@nichlaes This example provides a template for moving the MODE-based object creation from |
This issue is relates to discussion #951. In order to support these new features, the first step is to create a git mode for libms. We need to have a git configuration. This configuration can be specified in
.env
of libms as follows.The text was updated successfully, but these errors were encountered: