Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc Tags @serialField and @serialData #3033

Closed
Cyclone1337 opened this issue Jun 24, 2019 · 2 comments · Fixed by #3035
Closed

Javadoc Tags @serialField and @serialData #3033

Cyclone1337 opened this issue Jun 24, 2019 · 2 comments · Fixed by #3035

Comments

@Cyclone1337
Copy link

I found following problem: The real javadoc tag is @serialField and @Serialdata, but spoon expected @serial_Field and @serial_Data.

You can read it here:
https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#serialField
https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#serialData

@monperrus
Copy link
Collaborator

monperrus commented Jun 24, 2019 via email

@Egor18
Copy link
Contributor

Egor18 commented Jun 24, 2019

It looks like there is a problem with fromName method:

static Type fromName(String tagName) {
	for (Type t : Type.values()) {
		if (t.keyword.toUpperCase().equals(tagName.toUpperCase())) {
			return t;
		}
	}
	return UNKNOWN;
}

So it makes SERIALFIELD out of @serialField and not SERIAL_FIELD from the enum. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants