Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CtScanner doesn't scan all comments. #1712

Closed
pvojtechovsky opened this issue Nov 12, 2017 · 0 comments · Fixed by #1870
Closed

CtScanner doesn't scan all comments. #1712

pvojtechovsky opened this issue Nov 12, 2017 · 0 comments · Fixed by #1870
Labels

Comments

@pvojtechovsky
Copy link
Collaborator

The missing code in CtScanner can be found by change in CtScannerTest#testScannerCallsAllProperties.
Comment this code:

				if(getter.getName().equals("getComments")) {
					//ignore missing getComments ... until discussion about its contracts is finished
					return;
				}

and test will fail and report all missing scan(CtRole.COMMENT, ...) calls.

@surli surli added the bug label Nov 22, 2017
@monperrus monperrus changed the title CtScanner doesn't scans all comments. CtScanner doesn't scan all comments. Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants