fix(cdk:portal): remove targetHashMap #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
brenner8023
changed the title
Codecov Report
@@ Coverage Diff @@
## main #980 +/- ##
=======================================
Coverage 92.66% 92.66%
=======================================
Files 706 706
Lines 69024 69025 +1
Branches 8044 8044
=======================================
+ Hits 63961 63962 +1
Misses 5063 5063
Continue to review full report at Codecov.
|
|
@brenner8023 test 挂掉了 |
danranVm
approved these changes
Jun 28, 2022
| const targetHashmap: Record<string, HTMLElement> = {} | ||
| function tryFindElement(selector: string) { | ||
| const classSelector = `.${selector}` | ||
| return document.querySelector<HTMLElement>(selector) ?? document.querySelector<HTMLElement>(classSelector) |
There was a problem hiding this comment.
Suggested change
| return document.querySelector<HTMLElement>(selector) ?? document.querySelector<HTMLElement>(classSelector) | |
| return document.querySelector<HTMLElement>(selector) ?? document.querySelector<HTMLElement>(`.${selector}`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED: #949
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
需要维护一份targetHashMap的缓存
What is the new behavior?
删除targetHashMap，不维护缓存
Other information