Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:menu): cache expandedKeys when collapse changed #805

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 18, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #805 (199affd) into main (aa6a5aa) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 199affd differs from pull request most recent head a63a0a7. Consider uploading reports for the commit a63a0a7 to get more accurate results

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   84.38%   84.41%   +0.03%     
==========================================
  Files         467      467              
  Lines       12033    12034       +1     
  Branches     2891     2891              
==========================================
+ Hits        10154    10159       +5     
+ Misses       1879     1875       -4     
Impacted Files Coverage Δ
...ges/components/menu/src/composables/useExpanded.ts 81.81% <100.00%> (+11.22%) ⬆️
packages/pro/layout/src/contents/Sider.tsx 83.33% <100.00%> (+4.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa6a5aa...a63a0a7. Read the comment docs.

@danranVm danranVm merged commit 48bacb2 into IDuxFE:main Mar 18, 2022
@danranVm danranVm deleted the fix-menu branch March 18, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant