Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): component still interactable when disabled #1984

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

sallerli1
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

当 proSeaarch 被禁用的时候,组件依然可以操作,选择筛选条件

What is the new behavior?

修复以上问题

Other information

  1. 禁用的时候,阻止mousedown事件触发
  2. 禁用的时候,不设置任何激活的segment,全部设置为undefined

Copy link

idux-bot bot commented Aug 9, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.87%. Comparing base (76feba4) to head (80e8293).

Files Patch % Lines
packages/pro/search/src/ProSearch.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #1984     +/-   ##
=========================================
  Coverage   90.87%   90.87%             
=========================================
  Files         358      358             
  Lines       35826    35826             
  Branches     3901     2872   -1029     
=========================================
  Hits        32558    32558             
  Misses       3268     3268             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 2b5dc09 into IDuxFE:main Aug 12, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant