-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comp:date-picker): prevent elements with class name ix-overlay
's box-sizing
set to content-box
#1511
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1511 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 331 331
Lines 30801 30801
Branches 3533 3534 +1
=======================================
Hits 28568 28568
Misses 2233 2233
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
.@{overlay-prefix} { | ||
.reset-component(); | ||
|
||
&-arrow { | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with reviewing the code patch
The code patch adds an import statement to import a reset mixin and calls the mixin inside the @overlay-prefix
class. The code looks syntactically correct.
However, there are some potential bug risks. For example, if the reset mixin defined in the "../../../style/mixins/reset.less" file has any unexpected values, it could cause undesired behaviour. Therefore, it is important to review the reset mixin and ensure that it does not contain any unexpected values or code that could cause bugs.
In terms of improvement suggestions, if the reset mixin is used elsewhere in the codebase, it should be defined in a central location so that it can be easily accessed. This would make the code more organized and maintainable.
.@{overlay-prefix} { | ||
.reset-component(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.reset-component(); | |
.reset-component-new(); |
reset-component 被废弃掉了
.@{overlay-prefix} { | ||
.reset-component-new(); | ||
|
||
&-arrow { | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the code patch review :
The code patch looks good and there are no obvious bugs. However, it could be improved in a few ways. Firstly, it would be beneficial to add comments describing what each line of code does. This will help other developers understand the purpose of the code and make it easier for them to use. Secondly, it would be helpful to use more descriptive variable names for the mixins, so that the code is more readable. Finally, the reset-component-new() mixin should be tested to make sure it works as expected. These steps should help ensure the code patch is robust and secure.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information