Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:date-picker): prevent elements with class name ix-overlay's box-sizing set to content-box #1511

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

kovsu
Copy link
Member

@kovsu kovsu commented Mar 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

image

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 24, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1511 (720443a) into main (703122f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 720443a differs from pull request most recent head 03416ad. Consider uploading reports for the commit 03416ad to get more accurate results

@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage   92.75%   92.75%           
=======================================
  Files         331      331           
  Lines       30801    30801           
  Branches     3533     3534    +1     
=======================================
  Hits        28568    28568           
  Misses       2233     2233           
Impacted Files Coverage Δ
packages/components/button/src/Button.tsx 95.37% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

.@{overlay-prefix} {
.reset-component();

&-arrow {
position: absolute;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with reviewing the code patch

The code patch adds an import statement to import a reset mixin and calls the mixin inside the @overlay-prefix class. The code looks syntactically correct.

However, there are some potential bug risks. For example, if the reset mixin defined in the "../../../style/mixins/reset.less" file has any unexpected values, it could cause undesired behaviour. Therefore, it is important to review the reset mixin and ensure that it does not contain any unexpected values or code that could cause bugs.

In terms of improvement suggestions, if the reset mixin is used elsewhere in the codebase, it should be defined in a central location so that it can be easily accessed. This would make the code more organized and maintainable.

.@{overlay-prefix} {
.reset-component();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.reset-component();
.reset-component-new();

reset-component 被废弃掉了

.@{overlay-prefix} {
.reset-component-new();

&-arrow {
position: absolute;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the code patch review :

The code patch looks good and there are no obvious bugs. However, it could be improved in a few ways. Firstly, it would be beneficial to add comments describing what each line of code does. This will help other developers understand the purpose of the code and make it easier for them to use. Secondly, it would be helpful to use more descriptive variable names for the mixins, so that the code is more readable. Finally, the reset-component-new() mixin should be tested to make sure it works as expected. These steps should help ensure the code patch is robust and secure.

@danranVm danranVm merged commit 3fe76f2 into IDuxFE:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants