Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Faulty error thrown by ProgramCall.addParam #124

Merged
merged 1 commit into from
Mar 3, 2020
Merged

fix: Faulty error thrown by ProgramCall.addParam #124

merged 1 commit into from
Mar 3, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Feb 26, 2020

Resolves #123

When ProgramCall.addParam is passed a DS (2D array) the second parameter is an optional object for parm options.

addParam(data, [,options])

Latest code in master throws an error when passing an DS and no options object to ProgramCall.addParam.

`Error: Specifying the parameter type is required.`

An error should not be thrown if a DS is passed to addParam without providing the option object.
@abmusse abmusse requested a review from kadler February 26, 2020 22:03
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abmusse abmusse merged commit 75d081c into IBM:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Faulty error is thrown by ProgramCall.addParam
2 participants