fix: Remove trailing slash from url for extra cases #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmkeezer
force-pushed
the
trailing_slashes_2
branch
2 times, most recently
from
31886b0 to
f887677
Compare
dpopp07
reviewed
May 13, 2020
rmkeezer
force-pushed
the
trailing_slashes_2
branch
2 times, most recently
from
781bd07 to
732414c
Compare
rmkeezer
force-pushed
the
trailing_slashes_2
branch
from
732414c to
d6bdf7a
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
May 14, 2020
## [2.4.1](v2.4.0...v2.4.1) (2020-05-14) ### Bug Fixes * Remove trailing slash from url for extra cases ([#95](#95)) ([bcaa168](bcaa168))
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MasterOdin
reviewed
May 14, 2020
| @@ -141,7 +141,9 @@ export class BaseService { | |||
| * @param {string} url The base URL for the service. | |||
| */ | |||
| public setServiceUrl(url: string): void { | |||
| this.baseOptions.serviceUrl = url; | |||
| if (url) { | |||
There was a problem hiding this comment.
Given a parameter type of just string, this if statement would be superfluous. Should the type be changed to url?: string or the if statement removed?
There was a problem hiding this comment.
Yeah I think that's a fair point, the if statement probably doesn't need to be there. Or should be stricter and ensure that it's actually a string. In the JS case (which we think is most of our users), the type or requiredness isn't actually enforced. And stripTrailingSlash uses the .replace() method so it will throw a TypeError if url isn't a string.
I agree that the if statement as is isn't really that useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covered extra cases where trailing slash was not being removed when making a request.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)