feat(IAM Authenticator): add support for optional 'scope' property #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
approved these changes
Sep 17, 2020
| @@ -35,12 +35,14 @@ function onlyOne(a: any, b: any): boolean { | |||
| } | |||
|
|
|||
| const CLIENT_ID_SECRET_WARNING = 'Warning: Client ID and Secret must BOTH be given, or the header will not be included.'; | |||
| const SCOPE = 'scope'; | |||
There was a problem hiding this comment.
I don't know that a constant here is really necessary but I also don't have a problem with it. Up to you but I thought I would at least say that. If you find it helpful, I'm fine with it
jorge-ibm
force-pushed
the
feat/iam-scope
branch
from
236eb0b to
11970c5
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Sep 18, 2020
# [2.5.0](v2.4.5...v2.5.0) (2020-09-18) ### Features * **IAM Authenticator:** add support for optional 'scope' property ([#109](#109)) ([1c258b7](1c258b7))
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IAM /identity/token (get token) operation supports an optional "scope" form parameter which can be used to obtain an IAM access token having a limited set of scopes in this it can be used.
This commit adds support for the "Scope" field within the IamTokenManager & IamAuthenticator class. If set, the value of this field is sent as the "scope" form param in the "get token" request body when obtaining an access token.
ref: https://github.ibm.com/arf/planning-sdk-squad/issues/2167
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)