Adding Resize Spark #630
Merged
Adding Resize Spark #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daw3rd
requested changes
Sep 26, 2024
| @@ -0,0 +1,44 @@ | |||
| ARG BASE_IMAGE=quay.io/dataprep1/data-prep-kit/data-prep-kit-spark-3.5.2:0.2.1.dev0 | |||
There was a problem hiding this comment.
0.2.1.dev0 is no longer used in dev. to be consistent with other spark transforms (recent change), use latest as the tag. Note however, that this is generally overridden from the Makefile anyway by setting BASE_IMAGE when docker build is called. But for consistency it would be nice to change to latest.
|
|
||
| # set the version of python transform that this depends on. | ||
| set-versions: | ||
| $(MAKE) TRANSFORM_PYTHON_VERSION=${NOOP_PYTHON_VERSION} TOML_VERSION=$(NOOP_SPARK_VERSION) .transforms.set-versions |
| The set of dictionary keys holding [BlockListTransform](src/blocklist_transform.py) | ||
| configuration for values are as follows: | ||
|
|
||
| * _max_rows_per_table_ - specifies max documents per table |
There was a problem hiding this comment.
To better future-proof this file, shouldn't it defer to the python readme for configuration and CLI?
daw3rd
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding additional transforms to Spark pipeline
Related issue number (if any).
#586