Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set spark base image tag to that from .make.versions #626

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

daw3rd
Copy link
Member

@daw3rd daw3rd commented Sep 25, 2024

Why are these changes needed?

Releasing has problems since the tag for the base spark image was fixed to be latest.
It now is set from .make.versions, like other images.

Related issue number (if any).

#625

@daw3rd daw3rd requested a review from blublinsky September 25, 2024 15:29
@blublinsky
Copy link
Collaborator

Can you also fix https://github.com/IBM/data-prep-kit/blob/dev/.make.defaults#L52. We should not use data-prep-kit-spark-3.5.2 we already have it defined here https://github.com/IBM/data-prep-kit/blob/dev/data-processing-lib/spark/Makefile#L4. Maybe move Spark version make version, similar to https://github.com/IBM/data-prep-kit/blob/dev/.make.versions#L115

@blublinsky
Copy link
Collaborator

@daw3rd
Copy link
Member Author

daw3rd commented Sep 25, 2024

Also, I do not think it works as desired https://github.com/IBM/data-prep-kit/actions/runs/11036249651/job/30654242163?pr=626#step:4:9415

When using a version suffix (i.e. dev0), the image tags are always set to latest (see .make.versions), but when there is no suffix (i.e. when cutting a release), the tag should be the release versions (i.e. 0.2.1). The ci/cd link above is for a dev0 suffix so has the latest tag.

@blublinsky
Copy link
Collaborator

Also, I do not think it works as desired https://github.com/IBM/data-prep-kit/actions/runs/11036249651/job/30654242163?pr=626#step:4:9415

When using a version suffix (i.e. dev0), the image tags are always set to latest (see .make.versions), but when there is no suffix (i.e. when cutting a release), the tag should be the release versions (i.e. 0.2.1). The ci/cd link above is for a dev0 suffix so has the latest tag.

How can we prove this? It is soooo confusing

@daw3rd daw3rd requested a review from touma-I September 25, 2024 18:09
@daw3rd
Copy link
Member Author

daw3rd commented Sep 26, 2024

Also, I do not think it works as desired https://github.com/IBM/data-prep-kit/actions/runs/11036249651/job/30654242163?pr=626#step:4:9415

Can you be more specific?

@daw3rd daw3rd merged commit 7241d6a into dev Sep 26, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants